Skip to content

fix(web-app, admin): Angular 21+ modernizing for the event form preview dialog #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ktsorensenWX wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(web-app, admin): Angular 21+ modernizing for the event form preview dialog #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ed5e2a
fix(web-app, admin): modernizing the event form preview to Angular 21+
ktsorensenWX Sep 18, 2026
38966cc
updating tests & main event form module (moving declarations to imports)
ktsorensenWX Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...vent/admin-event-form/admin-event-form-preview/admin-event-form-preview.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ describe('AdminEventFormPreviewComponent', () => {

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [BrowserAnimationsModule, MatDialogModule],
declarations: [AdminEventFormPreviewComponent, TestHostComponent],
imports: [BrowserAnimationsModule, MatDialogModule, AdminEventFormPreviewComponent],
declarations: [TestHostComponent],
providers: [{
provide: MatDialog, useClass: MatDialogMock
}]
Expand Down
6 changes: 5 additions & 1 deletion ...min-event/admin-event-form/admin-event-form-preview/admin-event-form-preview.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ import { AdminEventFormPreviewDialogComponent } from './form-preview-dialog/admi
selector: 'admin-event-form-preview',
templateUrl: './admin-event-form-preview.component.html',
styleUrls: ['./admin-event-form-preview.component.scss'],
standalone: false
standalone: true,
// empty - template has no directives
imports: [

]
})
export class AdminEventFormPreviewComponent implements OnChanges {
@Input() formDefinition: any[];
Expand Down
7 changes: 2 additions & 5 deletions ...-event-form-preview/form-preview-dialog/admin-event-form-preview-dialog.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,13 @@ import { MatDialogModule as MatDialogModule, MAT_DIALOG_DATA as MAT_DIALOG_DATA
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { AdminEventFormPreviewDialogComponent } from './admin-event-form-preview-dialog.component';

import { AdminEventFormPreviewComponent } from '../admin-event-form-preview.component';

describe('AdminEventFormPreviewComponent', () => {
describe('AdminEventFormPreviewDialogComponent', () => {
let component: AdminEventFormPreviewDialogComponent
let fixture: ComponentFixture<AdminEventFormPreviewDialogComponent>

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [BrowserAnimationsModule, MatDialogModule],
declarations: [AdminEventFormPreviewComponent],
imports: [BrowserAnimationsModule, MatDialogModule, AdminEventFormPreviewDialogComponent],
providers: [{
provide: MAT_DIALOG_DATA,
useValue: {
Expand Down
11 changes: 9 additions & 2 deletions ...admin-event-form-preview/form-preview-dialog/admin-event-form-preview-dialog.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
import { Component, Inject, OnInit } from '@angular/core';
import { UntypedFormControl, UntypedFormGroup, Validators } from '@angular/forms';
import { MAT_DIALOG_DATA as MAT_DIALOG_DATA } from '@angular/material/dialog';
import { MatButtonModule } from '@angular/material/button';
import { MAT_DIALOG_DATA as MAT_DIALOG_DATA, MatDialogModule } from '@angular/material/dialog';
import { ObservationEditModule } from 'mage-web-app/observation/observation-edit/observation-edit.module';

@Component({
selector: 'admin-event-form-preview-dialog',
templateUrl: './admin-event-form-preview-dialog.component.html',
styleUrls: ['./admin-event-form-preview-dialog.component.scss'],
standalone: false
standalone: true,
imports: [
MatDialogModule,
MatButtonModule,
ObservationEditModule
]
})
export class AdminEventFormPreviewDialogComponent implements OnInit {

Expand Down
6 changes: 3 additions & 3 deletions web-app/src/app/admin/admin-event/admin-event-form/admin-event-form.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ import { AdminBreadcrumbModule } from '../../admin-breadcrumb/admin-breadcrumb.m

@NgModule({
declarations: [
AdminEventFormPreviewComponent,
AdminEventFormPreviewDialogComponent,
FormDetailsComponent,
FieldDialogComponent,
SymbologyDialogComponent,
Expand All @@ -55,7 +53,9 @@ import { AdminBreadcrumbModule } from '../../admin-breadcrumb/admin-breadcrumb.m
MatSelectModule,
MatDividerModule,
ObservationEditModule,
AdminBreadcrumbModule
AdminBreadcrumbModule,
AdminEventFormPreviewComponent,
AdminEventFormPreviewDialogComponent
],
exports: [
AdminEventFormPreviewComponent,
Expand Down
Loading