Skip to content

fix(web-app, admin): Angular 21+ modernizing for the event form preview dialog - #509

Open
ktsorensenWX wants to merge 2 commits into
developfrom
fix/admin-event-form-preview-angular-upgrading
Open

ktsorensenWX wants to merge 2 commits into
developfrom
fix/admin-event-form-preview-angular-upgrading

Conversation

@ktsorensenWX

@ktsorensenWX ktsorensenWX commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Converts AdminEventFormPreviewComponent and its child AdminEventFormPreviewDialogComponent to standalone components — converted together since the parent opens the dialog directly via MatDialog.open().
  • AdminEventFormPreviewDialogComponent imports ObservationEditModule (not the component) to bring in , which is still NgModule-based.
  • AdminEventFormPreviewComponent needs no imports at all — its template has no directives, and the dialog reference it uses is a TS-level call, not a template selector.

Testing

  • Fix stale declarations → imports in both components' .spec.ts files
  • Update admin-event-form.module.ts (move both to imports, keep in exports — event-details.component.html depends on the re-export)
  • Full npm run test-headless --prefix web-app pass
  • Manual check: open an event form, trigger the preview dialog, confirm it renders and closes correctly

@ktsorensenWX
ktsorensenWX marked this pull request as draft September 18, 2026 21:43
@ktsorensenWX ktsorensenWX changed the title fix(web-app, admin): modernizing the event form preview to Angular 21+ fix(web-app, admin): Angular 21+ modernizing for the event form preview dialog Sep 18, 2026
@ktsorensenWX
ktsorensenWX marked this pull request as ready for review September 21, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant