fetch-and-ingest-branch: Send Slack notications to test channel - #224
Merged
Conversation
This change was motivated by the unintentional bug introduced in #222 that would only be triggered by using Slack notifications. This allows to test branches and send notifications to the testing channel. As part of this change, I've added an organization level variable `TEST_SLACK_CHANNEL` that points our #scratch channel for testing Slack notifications.
joverlee521
force-pushed
the
fetch-and-ingest-branch
branch
from
November 15, 2023 22:26
a1ad642 to
a03f06d
Compare
Member
|
Nice, thanks! I had to look at docs to find where one sets that variable, it's here for reference: https://github.com/organizations/nextstrain/settings/variables/actions 
|
corneliusroemer
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was motivated by the unintentional bug introduced in #222 that would only be triggered by using Slack notifications. This allows to test branches and send notifications to the testing channel.
As part of this change, I've added an organization level variable
TEST_SLACK_CHANNELthat points our #scratch channel for testing Slack notifications.Checklist