Skip to content

test(nextly): an un-elevated batch row with its only field stripped is a no-op - #1806

Merged
mobeenabdullah merged 1 commit into
mainfrom
fix/bulk-update-test-reads-the-fixed-empty-patch
Sep 11, 2026
Merged

mobeenabdullah merged 1 commit into
mainfrom
fix/bulk-update-test-reads-the-fixed-empty-patch

Conversation

@mobeenabdullah

Copy link
Copy Markdown
Collaborator

What

main fails bulk-update-override-access.integration.test.ts:

× writes a field whose own rule refuses the caller when elevated
AssertionError: expected 1 to be +0

Why

Two PRs merged nine seconds apart, each green on its own base. #1801 (mine) pinned that an un-elevated batch row whose only field is stripped by a field rule fails, because the transactional update then issued an UPDATE with an empty SET. #1787 (another lane) fixed that underlying defect by stamping updated_at under its column name, so the row now succeeds as a no-op. Together, the assertion is stale.

The assertion now checks there is no error, and the case keeps the assertion it is actually about: the protected field did not change without elevation, and did with it. All 52 collections integration suites pass on main plus this.

Changeset

None. Test-only.

…s a no-op, not a failure

The case pinned the empty-patch failure the transactional update had,
which #1787 fixed by stamping updated_at under its column name. The two
merged nine seconds apart, each green on its own base, and together
left main red on this assertion. It now asserts no error and keeps the
assertion the case is about: the protected field did not change.
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: fc5edc69-b5ae-4449-b8a6-00da82061f00

📥 Commits

Reviewing files that changed from the base of the PR and between 95cfdda and 80ad8b7.

📒 Files selected for processing (1)
  • packages/nextly/src/domains/collections/__tests__/bulk-update-override-access.integration.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the scope: core nextly label Sep 11, 2026
@mobeenabdullah

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-11T17:35:59.359863Z 80ad8b7 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Whole-Repository Code Hygiene Summary

Full dead-code, duplication, and complexity report for the PR branch as it stands now. Playground is excluded. Quality gate enforcement on introduced issues is performed by the Changed files job.

🌿 Fallow

Warning

Review needed

⚠️ 73 code issues · ⚠️ 690 clone groups · ⚠️ 1045 health findings

See inline review comments for per-finding details.

Code issues (73)
Category Count
Unused files 2
Unused exports 5
Unused dependencies 19
Unused devDependencies 6
Unresolved imports 2
Unlisted dependencies 1
Circular dependencies 38
Duplication (690 groups · 28862 lines · 4.1%)
Locations Lines Tokens
schemas/_dialect-bundles/mysql.relations.ts:40-134
schemas/_dialect-bundles/postgres.relations.ts:40-134
schemas/_dialect-bundles/sqlite.relations.ts:40-134
95 593
cli/commands/db-sync-demote.ts:70-75
cli/commands/db-sync-promote.ts:38-43
cli/commands/dev-build.ts:100-105
cli/commands/dev-build.ts:179-184
cli/commands/dev-build.ts:299-304
cli/commands/dev-build.ts:411-416
cli/commands/dev-build.ts:552-557
cli/commands/dev-server.ts:575-580
cli/commands/dev-server.ts:840-845
cli/commands/dev-server.ts:1143-1148
cli/commands/migrate-field-groups.ts:110-115
6 70
entries/EntryList/EntryTableSkeleton.tsx:74-98
collection/components/CollectionTableSkeleton.tsx:94-118
field-group/components/FieldGroupTableSkeleton.tsx:90-114
plugins/components/PluginsTableSkeleton.tsx:86-110
singles/components/SinglesTableSkeleton.tsx:77-101
src/components/table-skeleton.tsx:100-124
25 89
collections/config/validate-config.ts:380-433
field-groups/config/validate-field-group.ts:185-238
singles/config/validate-single.ts:190-243
54 152
dispatcher/handlers/collection-dispatcher.ts:925-967
field-groups/services/field-group-table-provisioning.ts:186-236
singles/services/reconcile-single-companion.ts:110-160
51 149

… and 685 more groups.

Across 422 files.

Complexity (1045 functions above threshold)
File Function Severity Cyclomatic Cognitive CRAP Lines
singles/services/single-mutation-service.ts:981 <arrow> critical 251 ! 324 ! 13859.2 ! 1625
collections/services/collection-mutation-service.ts:6262 <arrow> critical 175 ! 178 ! 6790 ! 1288
src/init/reload-config.ts:1319 applyReload critical 144 ! 228 ! 4623 ! 1433
shared/lib/entry-validation.ts:223 validateFieldValue critical 109 ! 157 ! 2675.3 ! 432
blocks-engine/src/measure-bytes.ts:646 surveyDocument critical 102 ! 250 ! 137.1 ! 658

5018 files, 76951 functions analyzed (thresholds: cyclomatic > 20, cognitive > 15, CRAP >= 30)

Codebase health

Metric Value
Maintainability 91.7 / 100
Avg complexity 1.8

Tip

Run fallow fix --dry-run to preview auto-fixes.
Add /** @public */ above exports to preserve them.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80ad8b74a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@pkg-pr-new

pkg-pr-new Bot commented Sep 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@nextlyhq/adapter-drizzle

npm i https://pkg.pr.new/@nextlyhq/adapter-drizzle@80ad8b7

@nextlyhq/adapter-mysql

npm i https://pkg.pr.new/@nextlyhq/adapter-mysql@80ad8b7

@nextlyhq/adapter-postgres

npm i https://pkg.pr.new/@nextlyhq/adapter-postgres@80ad8b7

@nextlyhq/adapter-sqlite

npm i https://pkg.pr.new/@nextlyhq/adapter-sqlite@80ad8b7

@nextlyhq/admin

npm i https://pkg.pr.new/@nextlyhq/admin@80ad8b7

@nextlyhq/admin-css

npm i https://pkg.pr.new/@nextlyhq/admin-css@80ad8b7

@nextlyhq/blocks-engine

npm i https://pkg.pr.new/@nextlyhq/blocks-engine@80ad8b7

@nextlyhq/blocks-react

npm i https://pkg.pr.new/@nextlyhq/blocks-react@80ad8b7

@nextlyhq/builder

npm i https://pkg.pr.new/@nextlyhq/builder@80ad8b7

create-nextly-app

npm i https://pkg.pr.new/create-nextly-app@80ad8b7

@nextlyhq/eslint-plugin

npm i https://pkg.pr.new/@nextlyhq/eslint-plugin@80ad8b7

nextly

npm i https://pkg.pr.new/nextly@80ad8b7

@nextlyhq/plugin-form-builder

npm i https://pkg.pr.new/@nextlyhq/plugin-form-builder@80ad8b7

@nextlyhq/plugin-page-builder

npm i https://pkg.pr.new/@nextlyhq/plugin-page-builder@80ad8b7

@nextlyhq/plugin-sdk

npm i https://pkg.pr.new/@nextlyhq/plugin-sdk@80ad8b7

@nextlyhq/plugin-seo

npm i https://pkg.pr.new/@nextlyhq/plugin-seo@80ad8b7

@nextlyhq/storage-s3

npm i https://pkg.pr.new/@nextlyhq/storage-s3@80ad8b7

@nextlyhq/storage-uploadthing

npm i https://pkg.pr.new/@nextlyhq/storage-uploadthing@80ad8b7

@nextlyhq/storage-vercel-blob

npm i https://pkg.pr.new/@nextlyhq/storage-vercel-blob@80ad8b7

@nextlyhq/ui

npm i https://pkg.pr.new/@nextlyhq/ui@80ad8b7

commit: 80ad8b7

@mobeenabdullah
mobeenabdullah merged commit 746a714 into main Sep 11, 2026
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant