test(nextly): an un-elevated batch row with its only field stripped is a no-op - #1806
Conversation
…s a no-op, not a failure The case pinned the empty-patch failure the transactional update had, which #1787 fixed by stamping updated_at under its column name. The two merged nine seconds apart, each green on its own base, and together left main red on this assertion. It now asserts no error and keeps the assertion the case is about: the protected field did not change.
|
Warning Review limit reachedNext included review available in 41 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80ad8b74a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
@nextlyhq/adapter-drizzle
@nextlyhq/adapter-mysql
@nextlyhq/adapter-postgres
@nextlyhq/adapter-sqlite
@nextlyhq/admin
@nextlyhq/admin-css
@nextlyhq/blocks-engine
@nextlyhq/blocks-react
@nextlyhq/builder
create-nextly-app
@nextlyhq/eslint-plugin
nextly
@nextlyhq/plugin-form-builder
@nextlyhq/plugin-page-builder
@nextlyhq/plugin-sdk
@nextlyhq/plugin-seo
@nextlyhq/storage-s3
@nextlyhq/storage-uploadthing
@nextlyhq/storage-vercel-blob
@nextlyhq/ui
commit: |
What
mainfailsbulk-update-override-access.integration.test.ts:Why
Two PRs merged nine seconds apart, each green on its own base. #1801 (mine) pinned that an un-elevated batch row whose only field is stripped by a field rule fails, because the transactional update then issued an
UPDATEwith an emptySET. #1787 (another lane) fixed that underlying defect by stampingupdated_atunder its column name, so the row now succeeds as a no-op. Together, the assertion is stale.The assertion now checks there is no error, and the case keeps the assertion it is actually about: the protected field did not change without elevation, and did with it. All 52 collections integration suites pass on
mainplus this.Changeset
None. Test-only.