test(nextly): count the stripped batch row as processed, not just error-free

[mobeenabdullah]

What

Review on #1806, after it merged: the stripped un-elevated row asserted only errors: [], which a row skipped without being accounted for would also satisfy. The case now asserts successful: 1, failed: 0 and the row's id, so it proves the row was processed as a no-op.

Changeset

None. Test-only.

Summary by CodeRabbit

• Tests
  • Strengthened coverage for bulk updates to protected fields, verifying successful processing, absence of failures and errors, and inclusion of the affected entry identifier.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-11T18:20:40.161753Z	f8eefdf	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[mobeenabdullah]

@codex review

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c3da58c9-8e35-469d-9597-b6610f466103

📥 Commits

Reviewing files that changed from the base of the PR and between 746a714 and f8eefdf.

📒 Files selected for processing (1)

• packages/nextly/src/domains/collections/__tests__/bulk-update-override-access.integration.test.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The integration test now verifies that an unelevated protected-field batch update succeeds, reports no failures or errors, and returns the updated entry ID.

Changes

Bulk update access

Layer / File(s)	Summary
Validate bulk update results packages/nextly/src/domains/collections/__tests__/bulk-update-override-access.integration.test.ts	The test now checks one successful update, zero failed updates, and the expected entry ID, while retaining the no-errors assertion.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to f8eef

The PR improves coverage of the no-op batch result without changing production behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the test change and states that no changeset is needed. However, it does not follow the repository template because it omits the required Summary, Type of change, Related issu…	Update the description to use the repository template. Add the missing sections, mark the applicable test-only or refactor/chore classification, document the test commands or verification performed, and complete the checklist items. Keep th…

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: the test now counts a stripped batch row as processed instead of only checking that no errors occurred.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the test change and states that no changeset is needed. However, it does not follow the repository template because it omits the required Summary, Type of change, Related issues, Test plan, Checklist, Screenshots / recordings, and Notes for reviewers sections.

Resolution

Update the description to use the repository template. Add the missing sections, mark the applicable test-only or refactor/chore classification, document the test commands or verification performed, and complete the checklist items. Keep the existing explanation under Summary or Changeset as appropriate.

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/stripped-batch-row-counts-as-processed

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/nextly/src/domains/collections/__tests__/bulk-update-override-access.integration.test.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Whole-Repository Code Hygiene Summary

Full dead-code, duplication, and complexity report for the PR branch as it stands now. Playground is excluded. Quality gate enforcement on introduced issues is performed by the Changed files job.

🌿 Fallow

Warning

Review needed

⚠️ 73 code issues · ⚠️ 689 clone groups · ⚠️ 1044 health findings

See inline review comments for per-finding details.

Code issues (73)

Category	Count
Unused files	2
Unused exports	5
Unused dependencies	19
Unused devDependencies	6
Unresolved imports	2
Unlisted dependencies	1
Circular dependencies	38

Duplication (689 groups · 28845 lines · 4.1%)

Locations	Lines	Tokens
schemas/_dialect-bundles/mysql.relations.ts:40-134 schemas/_dialect-bundles/postgres.relations.ts:40-134 schemas/_dialect-bundles/sqlite.relations.ts:40-134	95	593
cli/commands/db-sync-demote.ts:70-75 cli/commands/db-sync-promote.ts:38-43 cli/commands/dev-build.ts:100-105 cli/commands/dev-build.ts:179-184 cli/commands/dev-build.ts:299-304 cli/commands/dev-build.ts:411-416 cli/commands/dev-build.ts:552-557 cli/commands/dev-server.ts:575-580 cli/commands/dev-server.ts:840-845 cli/commands/dev-server.ts:1143-1148 cli/commands/migrate-field-groups.ts:110-115	6	70
entries/EntryList/EntryTableSkeleton.tsx:74-98 collection/components/CollectionTableSkeleton.tsx:94-118 field-group/components/FieldGroupTableSkeleton.tsx:90-114 plugins/components/PluginsTableSkeleton.tsx:86-110 singles/components/SinglesTableSkeleton.tsx:77-101 src/components/table-skeleton.tsx:100-124	25	89
collections/config/validate-config.ts:380-433 field-groups/config/validate-field-group.ts:185-238 singles/config/validate-single.ts:190-243	54	152
dispatcher/handlers/collection-dispatcher.ts:925-967 field-groups/services/field-group-table-provisioning.ts:186-236 singles/services/reconcile-single-companion.ts:110-160	51	149

… and 684 more groups.

Across 422 files.

Complexity (1044 functions above threshold)

File	Function	Severity	Cyclomatic	Cognitive	CRAP	Lines
singles/services/single-mutation-service.ts:981	<arrow>	critical	251 !	324 !	13859.2 !	1625
collections/services/collection-mutation-service.ts:6262	<arrow>	critical	175 !	178 !	6790 !	1288
src/init/reload-config.ts:1319	applyReload	critical	144 !	228 !	4623 !	1433
shared/lib/entry-validation.ts:223	validateFieldValue	critical	109 !	157 !	2675.3 !	432
blocks-engine/src/measure-bytes.ts:646	surveyDocument	critical	102 !	250 !	137.1 !	658

5030 files, 77204 functions analyzed (thresholds: cyclomatic > 20, cognitive > 15, CRAP >= 30)

Codebase health

Metric	Value
Maintainability	91.7 / 100
Avg complexity	1.8

Tip

Run fallow fix --dry-run to preview auto-fixes.
Add /** @public */ above exports to preserve them.

[pkg-pr-new]

Open in StackBlitz

@nextlyhq/adapter-drizzle

npm i https://pkg.pr.new/@nextlyhq/adapter-drizzle@f8eefdf

@nextlyhq/adapter-mysql

npm i https://pkg.pr.new/@nextlyhq/adapter-mysql@f8eefdf

@nextlyhq/adapter-postgres

npm i https://pkg.pr.new/@nextlyhq/adapter-postgres@f8eefdf

@nextlyhq/adapter-sqlite

npm i https://pkg.pr.new/@nextlyhq/adapter-sqlite@f8eefdf

@nextlyhq/admin

npm i https://pkg.pr.new/@nextlyhq/admin@f8eefdf

@nextlyhq/admin-css

npm i https://pkg.pr.new/@nextlyhq/admin-css@f8eefdf

@nextlyhq/blocks-engine

npm i https://pkg.pr.new/@nextlyhq/blocks-engine@f8eefdf

@nextlyhq/blocks-react

npm i https://pkg.pr.new/@nextlyhq/blocks-react@f8eefdf

@nextlyhq/builder

npm i https://pkg.pr.new/@nextlyhq/builder@f8eefdf

create-nextly-app

npm i https://pkg.pr.new/create-nextly-app@f8eefdf

@nextlyhq/eslint-plugin

npm i https://pkg.pr.new/@nextlyhq/eslint-plugin@f8eefdf

nextly

npm i https://pkg.pr.new/nextly@f8eefdf

@nextlyhq/plugin-form-builder

npm i https://pkg.pr.new/@nextlyhq/plugin-form-builder@f8eefdf

@nextlyhq/plugin-page-builder

npm i https://pkg.pr.new/@nextlyhq/plugin-page-builder@f8eefdf

@nextlyhq/plugin-sdk

npm i https://pkg.pr.new/@nextlyhq/plugin-sdk@f8eefdf

@nextlyhq/plugin-seo

npm i https://pkg.pr.new/@nextlyhq/plugin-seo@f8eefdf

@nextlyhq/storage-s3

npm i https://pkg.pr.new/@nextlyhq/storage-s3@f8eefdf

@nextlyhq/storage-uploadthing

npm i https://pkg.pr.new/@nextlyhq/storage-uploadthing@f8eefdf

@nextlyhq/storage-vercel-blob

npm i https://pkg.pr.new/@nextlyhq/storage-vercel-blob@f8eefdf

@nextlyhq/ui

npm i https://pkg.pr.new/@nextlyhq/ui@f8eefdf

commit: f8eefdf

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: f8eefdfd9b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".