Skip to content

fix(wordings): Shorter labels for the share action buttons (to avoid longer words being truncated in languages other than English) #62880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jerome-Herbinet wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −6
Open

fix(wordings): Shorter labels for the share action buttons (to avoid longer words being truncated in languages other than English) #62880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apps/files_sharing/src/views/SharingDetailsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,15 +271,15 @@
<div class="sharingTabDetailsView__delete">
<NcButton
v-if="!isNewShare"
:aria-label="t('files_sharing', 'Delete share')"
:disabled="false"
:readonly="false"
variant="tertiary"
@click.prevent="removeShare">
<template #icon>
<CloseIcon :size="20" />
</template>
{{ t('files_sharing', 'Delete share') }}
<!-- TRANSLATORS: Button to delete the share -->
{{ t('files_sharing', 'Delete') }}
Comment thread
Jerome-Herbinet marked this conversation as resolved.
</NcButton>
</div>
<NcButton
Expand Down Expand Up @@ -434,9 +434,9 @@ export default {
default: {
if (this.share.id) {
// Share already exists
return t('files_sharing', 'Update share')
return t('files_sharing', 'Update') /** TRANSLATORS: Button to update share (apply changes) **/
} else {
return t('files_sharing', 'Create share')
return t('files_sharing', 'Create') /** TRANSLATORS: Button to create new share **/
}
}
}
Expand Down Expand Up @@ -627,9 +627,9 @@ export default {

shareButtonText() {
if (this.isNewShare) {
return t('files_sharing', 'Save share')
return t('files_sharing', 'Save') /** TRANSLATORS: Button to save new share **/
}
return t('files_sharing', 'Update share')
return t('files_sharing', 'Update') /** TRANSLATORS: Button to update share (apply changes) **/
},

resharingIsPossible() {
Expand Down
Loading