fix(wordings): Shorter labels for the share action buttons (to avoid longer words being truncated in languages other than English) - #62880
Open
Jerome-Herbinet wants to merge 1 commit into
Conversation
Jerome-Herbinet
added
design
susnux
reviewed
Aug 4, 2026
susnux
reviewed
Aug 4, 2026
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-shorter-share-buttons-actions-wordings
branch
2 times, most recently
from
August 4, 2026 12:12
6da47b6 to
9b662d4
Compare
Member
Author
|
@susnux : I have applied you co-authored commits and squashed all of them ; please check. |
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-shorter-share-buttons-actions-wordings
branch
from
August 4, 2026 12:13
9b662d4 to
d63dfcf
Compare
susnux
requested changes
Aug 4, 2026
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-shorter-share-buttons-actions-wordings
branch
from
August 4, 2026 13:13
38ef559 to
c6b3882
Compare
susnux
reviewed
Aug 4, 2026
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-shorter-share-buttons-actions-wordings
branch
from
August 4, 2026 14:16
1d231c2 to
73991c1
Compare
susnux
reviewed
Aug 4, 2026
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-shorter-share-buttons-actions-wordings
branch
2 times, most recently
from
August 5, 2026 09:00
7e5a959 to
1696566
Compare
Member
Author
Done ! :-) |
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-shorter-share-buttons-actions-wordings
branch
from
August 5, 2026 10:07
1696566 to
be12514
Compare
susnux
approved these changes
Aug 5, 2026
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-shorter-share-buttons-actions-wordings
branch
from
August 5, 2026 12:49
be12514 to
23cd771
Compare
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-shorter-share-buttons-actions-wordings
branch
3 times, most recently
from
August 6, 2026 11:48
8fe5a6d to
ebafca7
Compare
…tons (to avoid longer words being truncated in languages other than English) Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> fix(wordings): fix(wordings): Shorter labels for the share action buttons (to avoid longer words being truncated in languages other than English) Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> fix(wordings): Shorter labels for the share action buttons (to avoid longer words being truncated in languages other than English) Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> fix(wordings): Shorter labels for the share action buttons (to avoid longer words being truncated in languages other than English) Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Update apps/files_sharing/src/views/SharingDetailsTab.vue Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> fix(comment): adding comments Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> fix(comment): add one last comment Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Co-Authored-By: Ferdinand Thiessen <opensource@fthiessen.de>
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-shorter-share-buttons-actions-wordings
branch
from
August 7, 2026 12:00
ebafca7 to
8310c78
Compare
Contributor
|
playwright tests are related as the labels have been changed the POM has to be changed |
Member
Author
I'm sorry, @susnux … I'm a little confused because I don't understand what I'm supposed to do (I lack expertise in this particular area). Could you give me some guidance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current problem in French (many other languages may have the same issue) :
I suggest using only action verbs (one word per button) so that the information is clear and easy to read, and so that the interface isn't cluttered with buttons that are too large.