Hide personal settings of apps not enabled for the user - #62852
Merged
susnux merged 1 commit intoAug 4, 2026
Conversation
jancborchardt
requested review from
come-nc,
nfebe and
sorbaugh
and removed request for
a team
August 4, 2026 01:34
jancborchardt
added
bug
3. to review
This was referenced Aug 4, 2026
CarlSchwan
approved these changes
Aug 4, 2026
Member
|
Thanks! :) |
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
jancborchardt
force-pushed
the
fix/hide-personal-settings-of-apps-not-enabled-for-user
branch
from
August 4, 2026 10:30
f81b41d to
1fdc9fd
Compare
susnux
approved these changes
Aug 4, 2026
susnux
deleted the
fix/hide-personal-settings-of-apps-not-enabled-for-user
branch
August 4, 2026 16:21
Contributor
|
/backport to stable34 |
Member
|
This breaks the guests app which is overwriting/extending the class |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the Absence app showing even when not enabled for user. Fix nextcloud/absence#18
Initial PR at nextcloud/absence#24 but it’s not a fix only for that specific app. Also as requested by @CarlSchwan
Seems it needs backporting too as it would fix it on 34.
Checklist
3. to review, feature component)stable32)AI (if applicable)