Skip to content

Hide personal settings when app is not enabled for the user - #24

Closed
jancborchardt wants to merge 1 commit into
mainfrom
fix/hide-personal-settings-when-not-enabled
Closed

Hide personal settings when app is not enabled for the user#24
jancborchardt wants to merge 1 commit into
mainfrom
fix/hide-personal-settings-when-not-enabled

Conversation

@jancborchardt

@jancborchardt jancborchardt commented Aug 3, 2026

Copy link
Copy Markdown
Member

Fix #18

What was wrong: server registers info.xml settings classes from AppManager::loadApp(), which iterates unfiltered getEnabledApps(). Navigation, dashboard widgets and attribute routes all filter by isEnabledForUser(); personal settings do not. So absence's Personal form rendered for every user, while the API correctly rejected them.

Fix: lib/Settings/Personal.php: getSection() now returns null (documented "do not show" value of ISettings) when there's no user or the app isn't enabled for them.

Root cause is server-side and affects every group-restricted app with personal settings. Worth a separate server issue/PR (filter settings registration by isEnabledForUser); the app-side guard is the fix that ships on 34–36.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@jancborchardt
fix(settings): hide personal settings when app is not enabled for the…
e2b9310 
… user

Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
@jancborchardt jancborchardt self-assigned this Aug 3, 2026
@jancborchardt jancborchardt added 3. to review Waiting for reviews bug Something isn't working AI assisted This PR contains AI-assisted commits labels Aug 3, 2026
@jancborchardt jancborchardt mentioned this pull request Aug 3, 2026
Closed
@CarlSchwan

CarlSchwan commented Aug 3, 2026

Copy link
Copy Markdown
Member

I do think it's better to fix this in server than in every app with some settings

@jancborchardt jancborchardt mentioned this pull request Aug 4, 2026
Merged
9 tasks
@jancborchardt

jancborchardt commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

I do think it's better to fix this in server than in every app with some settings

Makes sense, server fix at nextcloud/server#62852

@jancborchardt
jancborchardt deleted the fix/hide-personal-settings-when-not-enabled branch August 4, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen Awaiting requested review from nickvergessen
@karlitschek karlitschek Awaiting requested review from karlitschek
@miaulalala miaulalala Awaiting requested review from miaulalala
@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@jancborchardt jancborchardt

Labels

3. to review Waiting for reviews AI assisted This PR contains AI-assisted commits bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Absence app shows even when not enabled for user?

2 participants

@jancborchardt @CarlSchwan