Skip to content

test: adapt DirectDownloadServiceTest for DirectController dependency changes #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saw-jan merged 2 commits into from
Aug 5, 2026
Merged

test: adapt DirectDownloadServiceTest for DirectController dependency changes #1133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e138131
test: add IManager dependency to DirectDownloadServiceTest
nabim777 Aug 4, 2026
650a005
test: adapt DirectDownloadServiceTest for DirectController dependency…
nabim777 Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 10 additions & 19 deletions tests/lib/Service/DirectDownloadServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,11 @@

namespace OCA\OpenProject\Service;

use OC\User\Session;
use OCA\DAV\Controller\DirectController;
use OCA\DAV\Db\DirectMapper;
use OCA\OpenProject\AppInfo\Application;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\EventDispatcher\IEventDispatcher;
use OCP\Files\IRootFolder;
use OCP\IRequest;
use OCP\IURLGenerator;
use OCP\IUserManager;
use OCP\Security\ISecureRandom;
use PHPUnit\Framework\TestCase;

class DirectDownloadServiceTest extends TestCase {
Expand Down Expand Up @@ -54,31 +49,27 @@ protected function setUp(): void {
$app = new Application();
$c = $app->getContainer();

/** @var DirectDownloadService directDownloadService */
$userManager = $c->get(IUserManager::class);
$user = $userManager->get(self::USER_ID);
$userSession = $c->get(Session::class);
$userSession->setUser($user);

/** @var DirectDownloadService $directDownloadService */
$directDownloadService = $c->get(DirectDownloadService::class);
$this->directDownloadService = $directDownloadService;

/** @var IRootFolder $root */
$root = $c->get(IRootFolder::class);
$this->userFolder = $root->getUserFolder(self::USER_ID);
$this->directController = new DirectController(
'dav',
$c->get(IRequest::class),
$root,
self::USER_ID,
$c->get(DirectMapper::class),
$c->get(ISecureRandom::class),
$c->get(ITimeFactory::class),
$c->get(IURLGenerator::class),
$c->get(IEventDispatcher::class)
);

$this->directController = $c->get(DirectController::class);
}

public static function tearDownAfterClass(): void {
$app = new Application();
$c = $app->getContainer();
$userManager = $c->get(IUserManager::class);
$user = $userManager->get('test');
$user = $userManager->get(self::USER_ID);
$user->delete();
}

Expand Down
Loading