test: adapt DirectDownloadServiceTest for DirectController dependency changes - #1133
Merged
Conversation
nabim777
force-pushed
the
fix/php-unit-test
branch
2 times, most recently
from
August 4, 2026 10:50
6d2cf9e to
51dbc91
Compare
nabim777
force-pushed
the
fix/php-unit-test
branch
from
August 4, 2026 10:59
51dbc91 to
2d99bf9
Compare
nabim777
marked this pull request as ready for review
August 4, 2026 11:14
nabim777
requested review from
Ashim-Stha,
Kharonus,
NobodysNightmare,
ba1ash,
dominic-braeunlein,
individual-it,
julien-nc,
lindenthal,
psatyal,
saw-jan and
wielinde
as code owners
August 4, 2026 11:14
saw-jan
reviewed
Aug 4, 2026
nabim777
force-pushed
the
fix/php-unit-test
branch
from
August 5, 2026 03:45
2d99bf9 to
8878f55
Compare
nabim777
force-pushed
the
fix/php-unit-test
branch
from
August 5, 2026 03:48
8878f55 to
8733300
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
… changes Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
nabim777
force-pushed
the
fix/php-unit-test
branch
from
August 5, 2026 03:52
8733300 to
650a005
Compare
saw-jan
approved these changes
Aug 5, 2026
Collaborator
Author
|
/backport to release/3.1 |
Contributor
|
The backport to # Switch to the target branch and update it
git checkout release/3.1
git pull origin release/3.1
# Create the new backport branch
git checkout -b backport/1133/release/3.1
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e1381311 650a0055
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1133/release/3.1Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Collaborator
Author
|
/backport 6609b41 to release/3.1 |
nabim777
added a commit
that referenced
this pull request
Aug 5, 2026
… changes (#1133) * test: add IManager dependency to DirectDownloadServiceTest Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * test: adapt DirectDownloadServiceTest for DirectController dependency changes Signed-off-by: nabim777 <nabinalemagar019@gmail.com> --------- Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
Collaborator
Author
|
/backport 6609b41 to release/2.11 |
nabim777
added a commit
that referenced
this pull request
Aug 5, 2026
… changes (#1133) * test: add IManager dependency to DirectDownloadServiceTest Signed-off-by: nabim777 <nabinalemagar019@gmail.com> * test: adapt DirectDownloadServiceTest for DirectController dependency changes Signed-off-by: nabim777 <nabinalemagar019@gmail.com> --------- Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
Collaborator
|
/backport to release/2.12 |
Contributor
|
The backport to # Switch to the target branch and update it
git checkout release/2.12
git pull origin release/2.12
# Create the new backport branch
git checkout -b backport/1133/release/2.12
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e1381311 650a0055
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1133/release/2.12Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Collaborator
|
/backport 6609b41 to release/2.11 |
Collaborator
|
/backport 6609b41 to release/2.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
DirectDownloadServiceTestto use the app container forDirectControllerinstead of building it manually.Issue
Due to the changes in the server PR (nextcloud/server#62809), a new constructor was added. Because of this, the following error occurs in the Psalm tests:
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile