Repository navigation
Let a Telegram connection mirror only the first and last text of a turn - #24
Merged
Merged
Conversation
Telegram got every text block of every mirrored turn, including narration Steve has no use for. A notify setting on the Telegram platform picks bookends (the default), all (the old behaviour) or cards (no turn text). Cards, questions, views and approvals are never filtered. client.js still needs a rebuild; not pushed.
The settings page draws the IM add form from src/shared/im-platforms.js, which client.js bundles.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Job DSB-IM-FILTER-20261112. Steve's answer (11-12, 1:47 PM ET): bookends plus a per-bot dial, for Telegram only. The app chat keeps showing everything.
What changes
notifyfield, "Messages", with three options:bookends(First and last, the default),all(Everything, today's behaviour) andcards(Cards only). An unset value resolves tobookends, so existing Telegram connections go quiet on install.bookends: a mirrored turn sends its first and last text block when the turn ends. A turn with one block sends one message.all: every text block goes out as it arrives, as before.cards: no turn text.notifykeep sending everything.The bookends hold lives in memory only and is cleared at
turn/start, so a turn that never ended cannot carry its text into the next one. A restart clears it too. On this pathdisplayItemsis called without the session, so items carry noturn; the hold keys on the session's ownturn/startandturn/endevents instead.Files
src/host/im/index.js: the outbound filter.src/shared/im-platforms.js: the field.client.js: rebuilt. The diff is only that platform entry.test/im.test.js: tests.Tests
allis unchanged;cardssends no turn text; a card opened mid-turn still goes out underbookends; the same undercards. 3 of them fail on the unpatched source.notify: 'all', because they assert per-block sending.build-client --check: exit 0.Not covered
im-updatewithfields.notify.Base:
stack/installed-0.3.5.