Skip to content

Send a Bot's held Telegram text before its card - #26

Merged
neotechnet merged 1 commit into
stack/installed-0.3.5from
fix/telegram-text-before-card
Nov 17, 2026
Merged

neotechnet merged 1 commit into
stack/installed-0.3.5from
fix/telegram-text-before-card

Conversation

@neotechnet

Copy link
Copy Markdown
Owner

Job card-order-telegram-20261116.

On a bookends Telegram connection (the default since #24) a turn's text was held until turn/end, while question, view and approval cards were sent the moment they opened, so the card reached the phone before the explanation written above it.

Now, before a card goes to a bookends connection, that Bot's held turn text is sent first and cleared. Text written after the card still follows at turn/end. notify all and notify cards are unchanged. A group approval (roomId set) does not flush the Bot's own chat text.

Scope: ds-bot/src/host/im/index.js, ds-bot/test/im.test.js.

Tests: im.test.js 49/49 with the fix; the three new ordering tests (question, view, approval) fail on the old code (46 pass, 3 fail). Full npm test 2303 tests, 2274 pass, 7 fail (the same known local failures as at #25, none in IM), 22 skipped. build-client --check exit 0. Lint 0 errors, 76 warnings.

On a bookends connection the turn text was held until turn/end, while a question, view or approval card went out the moment it opened. So a card reached the phone before the explanation written above it. Before a card goes out, that Bot's held text is now sent and cleared; text written after the card still follows at turn/end. Notify cards and all are unchanged.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T17:43:17.683046Z 261a35d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@neotechnet
neotechnet merged commit 98677f6 into stack/installed-0.3.5 Nov 17, 2026
14 checks passed
@neotechnet
neotechnet deleted the fix/telegram-text-before-card branch November 17, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant