Repository navigation
Send a Bot's held Telegram text before its card - #26
Merged
Merged
Conversation
On a bookends connection the turn text was held until turn/end, while a question, view or approval card went out the moment it opened. So a card reached the phone before the explanation written above it. Before a card goes out, that Bot's held text is now sent and cleared; text written after the card still follows at turn/end. Notify cards and all are unchanged.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Job card-order-telegram-20261116.
On a bookends Telegram connection (the default since #24) a turn's text was held until turn/end, while question, view and approval cards were sent the moment they opened, so the card reached the phone before the explanation written above it.
Now, before a card goes to a bookends connection, that Bot's held turn text is sent first and cleared. Text written after the card still follows at turn/end. notify all and notify cards are unchanged. A group approval (roomId set) does not flush the Bot's own chat text.
Scope: ds-bot/src/host/im/index.js, ds-bot/test/im.test.js.
Tests: im.test.js 49/49 with the fix; the three new ordering tests (question, view, approval) fail on the old code (46 pass, 3 fail). Full npm test 2303 tests, 2274 pass, 7 fail (the same known local failures as at #25, none in IM), 22 skipped. build-client --check exit 0. Lint 0 errors, 76 warnings.