Skip to content

TASK: Prepare tests for PHPUnit 12 #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdambekalns merged 2 commits into from
Aug 26, 2026
Merged

TASK: Prepare tests for PHPUnit 12 #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2ef35b
TASK: Replace deprecated addMethods() in tests
kdambekalns Aug 24, 2026
de7c1d3
TASK: Use createStub() for validator test doubles
kdambekalns Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/Unit/Core/Model/AbstractFinisherTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ protected function getAbstractFinisher()
*/
protected function getFinisherContext()
{
$this->formRuntime = $this->getAccessibleMock(FormRuntime::class, ['dummy'], [], '', false);
$this->formRuntime = $this->getAccessibleMock(FormRuntime::class, [], [], '', false);
return new FinisherContext($this->formRuntime);
}
}
4 changes: 2 additions & 2 deletions Tests/Unit/Core/Model/AbstractFormElementTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ public function isRequiredReturnsTrueIfNotEmptyValidatorIsAdded()
*/
protected function getFormElement(array $constructorArguments)
{
return $this->getMockBuilder(AbstractFormElement::class)->addMethods(['dummy'])->setConstructorArgs($constructorArguments)->getMock();
return $this->getMockBuilder(AbstractFormElement::class)->onlyMethods([])->setConstructorArgs($constructorArguments)->getMock();
}

/**
Expand All @@ -193,7 +193,7 @@ protected function getFormElement(array $constructorArguments)
*/
protected function getFormDefinitionWithProcessingRule($formElementIdentifier)
{
$mockProcessingRule = $this->getAccessibleMock(ProcessingRule::class, ['dummy']);
$mockProcessingRule = $this->getAccessibleMock(ProcessingRule::class, []);
$mockProcessingRule->_set('validator', new ConjunctionValidator());

$formDefinition = $this->getMockBuilder(FormDefinition::class)->onlyMethods(['getProcessingRule'])->setConstructorArgs(['foo'])->getMock();
Expand Down
22 changes: 11 additions & 11 deletions Tests/Unit/Core/Model/PageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ public function getElementsRecursivelyReturnsFirstLevelFormElements()
{
$page = new Page('foo');
/** @var AbstractFormElement|MockObject $element1 */
$element1 = $this->getMockBuilder(AbstractFormElement::class)->addMethods(['dummy'])->disableOriginalConstructor()->getMock();
$element1 = $this->getMockBuilder(AbstractFormElement::class)->onlyMethods([])->disableOriginalConstructor()->getMock();
/** @var AbstractFormElement|MockObject $element2 */
$element2 = $this->getMockBuilder(AbstractFormElement::class)->addMethods(['dummy'])->disableOriginalConstructor()->getMock();
$element2 = $this->getMockBuilder(AbstractFormElement::class)->onlyMethods([])->disableOriginalConstructor()->getMock();
$page->addElement($element1);
$page->addElement($element2);
Assert::assertSame([$element1, $element2], $page->getElementsRecursively());
Expand All @@ -118,17 +118,17 @@ public function getElementsRecursivelyReturnsRecursiveFormElementsInCorrectOrder
$page = new Page('foo');

/** @var AbstractFormElement|MockObject $element1 */
$element1 = $this->getMockBuilder(AbstractFormElement::class)->addMethods(['dummy'])->disableOriginalConstructor()->getMock();
$element1 = $this->getMockBuilder(AbstractFormElement::class)->onlyMethods([])->disableOriginalConstructor()->getMock();
/** @var Section|MockObject $element2 */
$element2 = $this->getMockBuilder(Section::class)->addMethods(['dummy'])->disableOriginalConstructor()->getMock();
$element2 = $this->getMockBuilder(Section::class)->onlyMethods([])->disableOriginalConstructor()->getMock();
/** @var AbstractFormElement|MockObject $element21 */
$element21 = $this->getMockBuilder(AbstractFormElement::class)->addMethods(['dummy'])->disableOriginalConstructor()->getMock();
$element21 = $this->getMockBuilder(AbstractFormElement::class)->onlyMethods([])->disableOriginalConstructor()->getMock();
/** @var AbstractFormElement|MockObject $element22 */
$element22 = $this->getMockBuilder(AbstractFormElement::class)->addMethods(['dummy'])->disableOriginalConstructor()->getMock();
$element22 = $this->getMockBuilder(AbstractFormElement::class)->onlyMethods([])->disableOriginalConstructor()->getMock();
$element2->addElement($element21);
$element2->addElement($element22);
/** @var AbstractFormElement|MockObject $element3 */
$element3 = $this->getMockBuilder(AbstractFormElement::class)->addMethods(['dummy'])->disableOriginalConstructor()->getMock();
$element3 = $this->getMockBuilder(AbstractFormElement::class)->onlyMethods([])->disableOriginalConstructor()->getMock();

$page->addElement($element1);
$page->addElement($element2);
Expand All @@ -142,7 +142,7 @@ public function aFormElementCanOnlyBeAttachedToASinglePage()
$this->expectException(FormDefinitionConsistencyException::class);

/** @var AbstractFormElement|MockObject $element */
$element = $this->getMockBuilder(AbstractFormElement::class)->addMethods(['dummy'])->disableOriginalConstructor()->getMock();
$element = $this->getMockBuilder(AbstractFormElement::class)->onlyMethods([])->disableOriginalConstructor()->getMock();

$page1 = new Page('bar1');
$page2 = new Page('bar2');
Expand All @@ -156,7 +156,7 @@ public function addElementAddsElementAndSetsBackReferenceToPage()
{
$page = new Page('bar');
/** @var AbstractFormElement|MockObject $element */
$element = $this->getMockBuilder(AbstractFormElement::class)->addMethods(['dummy'])->disableOriginalConstructor()->getMock();
$element = $this->getMockBuilder(AbstractFormElement::class)->onlyMethods([])->disableOriginalConstructor()->getMock();
$page->addElement($element);
Assert::assertSame([$element], $page->getElements());
Assert::assertSame($page, $element->getParentRenderable());
Expand Down Expand Up @@ -306,7 +306,7 @@ public function removeElementThrowsExceptionIfElementIsNotOnCurrentPage()
$formDefinition = $this->getDummyFormDefinition();
$page1 = $formDefinition->createPage('myPage1');
/** @var AbstractFormElement|MockObject $element1 */
$element1 = $this->getMockBuilder(AbstractFormElement::class)->addMethods(['dummy'])->disableOriginalConstructor()->getMock();
$element1 = $this->getMockBuilder(AbstractFormElement::class)->onlyMethods([])->disableOriginalConstructor()->getMock();

$page1->removeElement($element1);
}
Expand All @@ -316,7 +316,7 @@ public function validatorKeyCorrectlyAddsValidator()
{
$formDefinition = $this->getDummyFormDefinition();

$mockProcessingRule = $this->getAccessibleMock(ProcessingRule::class, ['dummy']);
$mockProcessingRule = $this->getAccessibleMock(ProcessingRule::class, []);
/** @noinspection PhpUndefinedMethodInspection */
$mockProcessingRule->_set('validator', new ConjunctionValidator());
$formDefinition->expects($this->any())->method('getProcessingRule')->with('asdf')->willReturn($mockProcessingRule);
Expand Down
4 changes: 2 additions & 2 deletions Tests/Unit/Core/Model/ProcessingRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ public function getValidatorsReturnsAnEmptyCollectionByDefault()
public function getValidatorsReturnsPreviouslyAddedValidators()
{
/** @var ValidatorInterface $mockValidator1 */
$mockValidator1 = $this->createMock(ValidatorInterface::class);
$mockValidator1 = $this->createStub(ValidatorInterface::class);
$this->processingRule->addValidator($mockValidator1);
/** @var ValidatorInterface $mockValidator2 */
$mockValidator2 = $this->createMock(ValidatorInterface::class);
$mockValidator2 = $this->createStub(ValidatorInterface::class);
$this->processingRule->addValidator($mockValidator2);

$validators = $this->processingRule->getValidators();
Expand Down
4 changes: 2 additions & 2 deletions Tests/Unit/Core/Renderer/FormRuntimeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public function valuesSetInConstructorCanBeReadAgain()
$mockActionRequest->expects(self::once())->method('createSubRequest')->willReturn($mockFormSubRequest);
$actionResponse = new ActionResponse();

$formRuntime = $this->getAccessibleMock(FormRuntime::class, ['dummy'], [$formDefinition, $mockActionRequest, $actionResponse]);
$formRuntime = $this->getAccessibleMock(FormRuntime::class, [], [$formDefinition, $mockActionRequest, $actionResponse]);

Assert::assertSame($mockActionRequest, $formRuntime->getRequest()->getParentRequest());
Assert::assertInstanceOf(ActionResponse::class, $formRuntime->getResponse());
Expand Down Expand Up @@ -204,6 +204,6 @@ protected function createFormRuntime(FormDefinition $formDefinition)
$mockActionRequest = $this->getMockBuilder(ActionRequest::class)->disableOriginalConstructor()->getMock();
$actionResponse = new ActionResponse();

return $this->getAccessibleMock(FormRuntime::class, ['dummy'], [$formDefinition, $mockActionRequest, $actionResponse]);
return $this->getAccessibleMock(FormRuntime::class, [], [$formDefinition, $mockActionRequest, $actionResponse]);
}
}
Loading