TASK: Prepare tests for PHPUnit 12 - #184
Merged
Merged
Conversation
MockBuilder::addMethods() is removed in PHPUnit 12 without replacement. All occurrences here are the ['dummy'] idiom, meaning "mock a method that does not exist so that none of the real ones get replaced". Since PHPUnit 10 onlyMethods([]) expresses exactly that: * getAccessibleMock(X::class, ['dummy']) becomes getAccessibleMock(X::class, []). * On a raw mock builder, addMethods(['dummy']) becomes ->onlyMethods([]). Dropping the call entirely would be wrong - without any onlyMethods()/ addMethods() call the builder mocks *every* method.
The two validators in `getValidatorsReturnsPreviouslyAddedValidators` have no expectations on them, so a stub is the fitting double.
mhsdesign
approved these changes
Aug 25, 2026
mhsdesign
left a comment
mhsdesign
left a comment
Member
There was a problem hiding this comment.
Looks harmless thanks.
Cannot say anything regarding which branch to target or which version this will be released in ... dont do things in the form package;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.