Repository navigation
Back-port the 77 Spanish-only exercise descriptions to every other locale - #324
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #167 (Chore/translate to es) did more than translate: it invented 77
# --description--sections for exercises whose English originals have none. They exist inesand in no other locale — so eleven locales have been missing theory that Spanish learners have had for months. 34 were already live; the other 43 surfaced when #322 stopped truncating_theory.md.The gap is visible in
curriculum.json.trainUntilcounts the exercises in an argument that have a description (json_creator.dart:134), and it reads 41 fores/python/conditionalStatementsagainst 6 for every other locale.python/conditionalStatementsc/conditionalStatementsjavascript/conditionalStatementsjavascript/comparisonLogicalOperatorsswift/enumerationsWhat was done
The Spanish text was used as the source of intent, not as a string to translate. Each description was written against the exercise it belongs to, then translated outward into the ten remaining locales.
eskeeps its own wording.Every technical claim was checked. Two things that came out of that:
ifcondition. These exercises happen to writeif (True):, and a first draft turned that into "the parenthesized condition" — the same false claim that already shipped once in Spanish and had to be corrected in Stop truncating theory pages at the first exercise without a description #322. Entries 18, 35 and 41 now say the parentheses are optional grouping.es/swift/enumerations/5.mdwas a byte-identical duplicate ofes/swift/enumerations/4.md, so thatCaseIterableparagraph printed twice in a row on the Spanish theory page. It now carries theforEachmaterial that exercise 5 actually teaches. This is the onlyesfile touched.Descriptions are concatenated into
_theory.md, where no exercise is present to refer to, so none of them restate the task ("fill in the blanks", "this time…"). Where an exercise is a pure repetition drill, the description states something true instead — the sixcomparisonLogicalOperatorsre-drills now cover==vs===coercion, lexicographic string comparison, andNaNcomparing false against everything.Diff shape
esreplacement (−10)._theory.mdfiles, +3709 / −10 — mirrors the exercise delta exactly.curriculum.json, +55/−55 — 11 locales × 5 arguments, eachtrainUntilmoving to the valueesalready had.esitself is unchanged.Checks
trainUntil/totalExercisesfor the five arguments:(41,43) (25,42) (24,45) (15,23) (5,9).--description--each, same fence count as English, fenced code byte-identical to English. One intended exception — the prose comment// runs when condition is trueinc/conditionalStatements/7.mdis translated per locale, matching how sibling descriptions already handle comments.+275436: All tests passed!Noticed, not fixed here
pt/javascript/conditionalStatementsandpt/python/conditionalStatementsstore their older descriptions without diacritics ("A tomada de decisao e necessaria"), unlike the rest ofpt. The new text is properly accented; the pre-existing paragraphs on those two theory pages are not.