Protect against buffer overflows and null pointer dereferences#9
Merged
Conversation
bformata() and bassignformat() have calls to vsnprintf() that can potentially overflow the buffer if the value of the second parameter is extremely large This adds some validation that bails out if the value reaches INT_MAX
rdmark
force-pushed
the
buffer-overflow
branch
3 times, most recently
from
d078ff4 to
4e64e98
Compare
rdmark
changed the title
The check framework does an assertion for null pointers in the test data, but continues test execution even when the assertion fails, which leads to the potential null pointer dereference when subsequent tests does other assertions on the same pointers Now we instead abort the test with ck_abort_msg() when a null pointer is encountered
|
Collaborator
Author
|
@msteinert What do you think about these changes? They should bring us to green status in both the Security and Reliability categories in SonarQube. The 10% code duplication failure can't be avoided I think given the nature of the code, but I'm open to suggestions. |
Owner
|
Sorry for the delay getting to your PRs, I was on vacation last week. I'm going to try to get caught up in the next couple days. |
msteinert
approved these changes
Aug 11, 2025
msteinert
left a comment
msteinert
left a comment
Owner
There was a problem hiding this comment.
Looks good to me.
I agree, it doesn't seem possible to avoid duplication here.
Collaborator
Author
|
Cheers! After merging this PR, one new issue and a few old ones remain, so I'll prepare a new one shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset should resolve all Security and Reliability bugs detected by SonarQube
Potential buffer overflow in bstrlib.c:
bformata() and bassignformat() have calls to vsnprintf() that can potentially overflow the buffer if the value of the second parameter (length) is extremely large
This adds some validation that bails out if the value reaches INT_MAX
Potential null pointer dereference in bstest.c:
The check framework does an assertion for null pointers in the test data, but continues test execution even when the assertion fails, which leads to the potential null pointer dereference when subsequent tests does other assertions on the same pointers
Now we instead abort the test with ck_abort_msg() when a null pointer is encountered