Address a straggler buffer overflow, and add safeguard after test abort#15
Merged
Conversation
bformata() and bassignformat() have calls to vsnprintf() that can potentially overflow the buffer if the value of the second parameter is extremely large This adds some validation that bails out if the value reaches INT_MAX The same fix was applied elsewhere in this file
The check library does a longjmp after an abort so this return statement isn't actually ever reached, but adding this safeguard to protect against potential library bugs, and to make it explicit for static analysis that execution exists after an abort
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, add a third data length check akin to what was done in #9
Second, explicitly return after test abort (primarily to signal to SonarQube that the test exits at that point)