Skip to content

feat(nimbus): Add holdback checkbox to Experimenter #16137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yashikakhurana wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −0
Open

feat(nimbus): Add holdback checkbox to Experimenter #16137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions experimenter/experimenter/nimbus_ui/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,14 @@ class NimbusUIConstants:
"project_impact": """Set an impact rating so others can understand the scale of
this experiment's effect.""",
}
HOLDBACK_LABEL = "Is this a holdback experiment?"
HOLDBACK_HELP_TEXT = (
"Holdback experiments continuously enroll users and run for an extended period. "
"Analysis will automatically run each week based on a 21-day observation period, "
"and an enrollment period encompassing the rest of the time between launch and "
"21 days from the run date."
)

COENROLLMENT_NOTE = (
"Note: This feature supports co-enrollment with other experiments/rollouts "
"for the selected versions."
Expand Down
4 changes: 4 additions & 0 deletions experimenter/experimenter/nimbus_ui/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,9 @@ class NimbusBranchesForm(NimbusChangeLogFormMixin, forms.ModelForm):
requires_restart = forms.BooleanField(
required=False, widget=forms.CheckboxInput(attrs={"class": "form-check-input"})
)
is_holdback = forms.BooleanField(
required=False, widget=forms.CheckboxInput(attrs={"class": "form-check-input"})
)

update_on_change_fields = (
"equal_branch_ratio",
Expand All @@ -744,6 +747,7 @@ class Meta:
"firefox_labs_description_links",
"firefox_labs_group",
"requires_restart",
"is_holdback",
)
widgets = {
"is_rollout": forms.CheckboxInput(attrs={"class": "form-check-input"}),
Expand Down
11 changes: 11 additions & 0 deletions experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/edit_branches.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,17 @@ <h4>Branches</h4>
{% for error in validation_errors.is_rollout %}<div class="form-text text-danger">{{ error }}</div>{% endfor %}
</div>
</div>
<div class="row mb-3">
<div class="col">
<div class="form-check">
{{ form.is_holdback }}
<label class="form-check-label" for="id_is_holdback">{{ NimbusUIConstants.HOLDBACK_LABEL }}</label>
</div>
<p class="form-text">{{ NimbusUIConstants.HOLDBACK_HELP_TEXT }}</p>
{% for error in form.is_holdback.errors %}<div class="invalid-feedback">{{ error }}</div>{% endfor %}
{% for error in validation_errors.is_holdback %}<div class="form-text text-danger">{{ error }}</div>{% endfor %}
</div>
</div>
<div class="row mb-3">
<div class="col">
<div class="form-check">
Expand Down
Loading