feat(nimbus): Add holdback checkbox to Experimenter#16137
Open
yashikakhurana wants to merge 1 commit into
Open
feat(nimbus): Add holdback checkbox to Experimenter#16137yashikakhurana wants to merge 1 commit into
yashikakhurana wants to merge 1 commit into
Conversation
yashikakhurana
requested review from
freshstrangemusic,
jaredlockhart and
mikewilli
as code owners
Contributor
Author
|
Blocked on this #16136 |
Contributor
Author
|
mikewilli
previously requested changes
Jun 30, 2026
Contributor
There was a problem hiding this comment.
I think this is the same change as in #16136 so shouldn't be in this PR.
Contributor
Author
There was a problem hiding this comment.
yeah branching from the pr
Contributor
There was a problem hiding this comment.
Maybe this is the best spot, but I wonder if this should go in the Overall form? Or maybe Branches since that's where the "Is this a rollout?" question is?
Contributor
Author
There was a problem hiding this comment.
yeah was not sure what's the best place to put, I can move it to branches
yashikakhurana
force-pushed
the
16085
branch
3 times, most recently
from
9b5bd4d to
10aab52
Compare
Contributor
Author
|
@mikewilli okay I have cleaned this PR since is holdback is available on main now, previously I was branching out from the other branches and hence all the changes, also moved the field to the Branches page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #16085