Repository navigation
fix(swiss): don't flag ScalingLimited as a scaler warning - #104
Merged
aceforeverd merged 1 commit intoOct 26, 2026
Merged
Conversation
The cluster-resources scaler card took the first condition at False as a failure, so a healthy LLMScaler showed ScalingLimited=False (DesiredWithinRange) as an amber badge, and its condition dot as a warning. - scalerFailing: only AbleToScale=False or ScalingActive=False fails, with DecisionAvailable standing in when ScalingActive is absent (operator 0.5.0 writes only that one) - the scaler card badge and the standalone deploy page's scaling step use it - the scaler card draws ScalingLimited, and DecisionAvailable when ScalingActive is present, with a neutral dot; other cards are unchanged Co-authored-by: aceforeverd <11715200+aceforeverd@users.noreply.github.com>
huskcass
commented
Oct 26, 2026
huskcass
left a comment
huskcass
left a comment
Collaborator
Author
There was a problem hiding this comment.
No blockers.
Verdict: correct for new-operator and 0.5.0 scalers, route card and other kinds unchanged; good to merge.
— Review Golden
aceforeverd
added a commit
that referenced
this pull request
Oct 26, 2026
The cluster-resources scaler card took the first condition at False as a failure, so a healthy LLMScaler showed ScalingLimited=False (DesiredWithinRange) as an amber badge, and its condition dot as a warning. - scalerFailing: only AbleToScale=False or ScalingActive=False fails, with DecisionAvailable standing in when ScalingActive is absent (operator 0.5.0 writes only that one) - the scaler card badge and the standalone deploy page's scaling step use it - the scaler card draws ScalingLimited, and DecisionAvailable when ScalingActive is present, with a neutral dot; other cards are unchanged Co-authored-by: huskcass <333684917+huskcass@users.noreply.github.com> Co-authored-by: aceforeverd <11715200+aceforeverd@users.noreply.github.com>
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does and why
On a healthy LLMScaler the Resources tab's scaler card showed
ScalingLimited=False/DesiredWithinRangeas an amber warning badge, and its row in the condition list got a warning dot. The card took the first condition atFalseas a failure.ScalingLimitedis informational in both states, andFalseis the normal one.Rule, in a new
scalerFailingincomponents/ReleaseObjects.tsx:AbleToScale=FalseScalingActive=FalseDecisionAvailable=False, noScalingActiveScalingLimited, either statusDecisionAvailablenext toScalingActiveroutes/DeploymentDetail.tsx) uses the samescalerFailing.Conditionstakes an optionalneutrallist and only the scaler card passes one.DecisionAvailable, and only under the Custom provider. It is read in place ofScalingActivewhen that is absent. A 0.5.0 scaler on Prometheus has no conditions and shows by its replica counts as before.Complements #101, which fixed the same rule for the Overview tab's Scaling tile.
Which issue(s) this PR fixes
Refs #101
How it was tested
components/scaler-conditions.test.ts:ScalingLimited=Falseis not a failure;AbleToScale=FalseandScalingActive=Falseare;DecisionAvailable=Falsefails only whenScalingActiveis absent.npm run typecheck,npm test(48 files, 434 tests),npm run buildandnpm run build:swisspass inweb/.Checks
go test ./...andgofmt -l .is empty (no Go change)npm run typecheck && npm test && npm run buildinweb/(ifweb/changed)helm lint --strict helm/console(if the chart changed)Notes for reviewers
This edits
web/src/modules/swissdirectly. swiss now builds its UI from this repo (itsweb/consolesubmodule,npm run build:swiss), so there is no upstream copy to fix first.Release note