[huskcass]

What type of PR is this?

• bug fix

What this PR does and why

Follow-up to #104. A scaler hold is AbleToScale=True with reason RolloutInProgress, ScaleDownSettling or ScaleDownStabilized. It is not a state of its own: a scaler is either ok or bad.

Surface	While held
Overview Scaling tile (inferences)	ok, "N replicas, steady"
Deploy page Scaling step (swiss)	ok, "N replicas, steady"
Scaler card badge	success "steady"
Scaler card condition list	the AbleToScale dot is yellow (bg-warning)

• A hold reports as steady even when desired and current replicas differ. A failure (AbleToScale=False or ScalingActive=False) still wins.
• Conditions takes an optional warn list of condition types. Only the scaler card passes one (["AbleToScale"], while held); other callers are unchanged.
• web/src/modules/swiss/lib/scaler.ts holds the failing, hold and neutral rules (scalerFailing, scalerHold, scalerNeutral), shared by the scaler card, the deploy page and the inferences scalerStep.
• The unused steps.scaler.deferred locale strings are removed.

Which issue(s) this PR fixes

Refs #104

How it was tested

• inferences/lib.test.ts and swiss/lib/scaler.test.ts: each of the three hold reasons is ok/steady with current 3, desired 1; a hold together with ScalingActive=False is bad.
• swiss/lib/scaler.test.ts (replaces components/scaler-conditions.test.ts): scalerFailing, scalerHold, scalerNeutral, and the deploy page's scalerStep for steady, failing, a healthy 0.5.0 object (DecisionAvailable=True) and a Prometheus object with no conditions.
• swiss/components/Conditions.test.tsx: renders Conditions and checks that the AbleToScale dot is bg-warning only when it is listed in warn.
• npm test (49 files, 446 tests), npm run typecheck, npm run build and npm run build:swiss pass in web/.

Checks

• go test ./... and gofmt -l . is empty (no Go change)
• npm run typecheck && npm test && npm run build in web/ (if web/ changed)
• helm lint --strict helm/console (if the chart changed)
• Docs updated where behaviour, a config key or a chart value moved
• No internal hostnames, IPs, registries or credentials

Notes for reviewers

scalerStep in routes/DeploymentDetail.tsx is now exported so it can be tested.

Release note

A held autoscaler step now shows as steady, with only its AbleToScale condition marked in the cluster resources.

[huskcass]

No blockers.

Verdict: rules now live once in swiss/lib/scaler.ts, Overview output is unchanged, and holds read the same on the card, deploy page and Overview; good to merge.

— Review Golden

[huskcass]

No blockers.

Verdict: holds now read as steady on the Overview, deploy page and scaler card with only a yellow AbleToScale dot, failure still wins, and the bad rule is unchanged; good to merge.

— Review Golden