-
Notifications
You must be signed in to change notification settings - Fork 34
Add PR template for new PR's #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GiladShapira94
merged 11 commits into
mlrun:development
from
GiladShapira94:add-pr-template
Apr 14, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a8dd61c
Add mlrun 1.11.0-rc28 tag version
GiladShapira94 7645b2a
Merge remote-tracking branch 'upstream/development' into development
GiladShapira94 c09aeaf
Merge remote-tracking branch 'upstream/development' into development
GiladShapira94 34dab64
Merge remote-tracking branch 'upstream/development' into development
GiladShapira94 9218cd9
Merge remote-tracking branch 'upstream/development' into development
GiladShapira94 d6b284c
Merge remote-tracking branch 'upstream/development' into development
GiladShapira94 9815a06
Merge remote-tracking branch 'upstream/development' into development
GiladShapira94 91b44d6
Merge remote-tracking branch 'upstream/development' into development
GiladShapira94 9921455
Merge remote-tracking branch 'upstream/development' into development
GiladShapira94 dc34526
add pull_request_template.md
GiladShapira94 487ad26
fix after review
GiladShapira94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| ### 📝 Description | ||
| <!-- A short summary of what this PR does. --> | ||
| <!-- Include any relevant context or background information. --> | ||
|
|
||
| --- | ||
|
|
||
| ### 🛠️ Changes Made | ||
| <!-- - Key changes (e.g., added feature X, refactored Y, fixed Z) --> | ||
|
|
||
| --- | ||
|
|
||
| ### ✅ Checklist | ||
| - [ ] I have tested the changes in this PR | ||
| - [ ] I confirmed whether my changes require a change in documentation and if so, I created another PR in MLRun for the relevant documentation. | ||
| - [ ] I confirmed whether my changes require a changes in QA tests, for example: credentials changes, resources naming change and if so, I updated the relevant Jira ticket for QA. | ||
| - [ ] I increased the Chart version in `charts/mlrun-ce/Chart.yaml`. | ||
| - [ ] I confirmed that the installation works both on a local Docker Desktop environment and on a real cluster when using the required [prerequisites](https://docs.mlrun.org/en/stable/install-mlrun-ce/kubernetes-install.html#prerequisites). | ||
| - [ ] If installation issues were found, I updated the relevant Jira ticket with the issue and steps to reproduce, or updated the prerequisites documentation if the issue is related to missing or outdated prerequisites. | ||
| - [ ] If needed, update https://github.com/mlrun/ce/blob/development/charts/mlrun-ce/README.md with the relevant installation instructions and version Matrix. | ||
| - [ ] If needed, update the following values files for multi namespace support: | ||
| - [ ] [Admin values](https://github.com/mlrun/ce/blob/development/charts/mlrun-ce/admin_installation_values.yaml) | ||
| - [ ] [User values Node Port](https://github.com/mlrun/ce/blob/development/charts/mlrun-ce/non_admin_installation_values.yaml) | ||
| - [ ] [User values ClusterIP](https://github.com/mlrun/ce/blob/development/charts/mlrun-ce/non_admin_cluster_ip_installation_values.yaml) | ||
|
|
||
| --- | ||
|
|
||
| ### 🧪 Testing | ||
| <!-- - How it was tested (unit tests, manual, integration) --> | ||
| <!-- - Any special cases covered. --> | ||
|
|
||
| --- | ||
|
|
||
| ### 🔗 References | ||
| - Ticket link: | ||
| - External links: | ||
| - Design docs links (Optional): | ||
| --- | ||
|
|
||
| ### 🚨 Breaking Changes? | ||
|
|
||
| - [ ] Yes (explain below) | ||
| - [ ] No | ||
|
|
||
| <!-- If yes, describe what needs to be changed downstream: --> | ||
|
|
||
| --- | ||
|
|
||
| ### 🔍️ Additional Notes | ||
| <!-- Anything else reviewers should know (follow-up tasks, known issues, affected areas etc.). --> | ||
| <!-- ### 📸 Screenshots / Logs --> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In CE, we don’t include these tests. The requirement should be more general and allow users to describe their testing approach in a flexible way.