Add PR template for new PR's#287
Merged
GiladShapira94 merged 11 commits intomlrun:developmentfrom Apr 14, 2026
Merged
Conversation
yaelgen
requested changes
Apr 14, 2026
Member
yaelgen
left a comment
yaelgen
left a comment
There was a problem hiding this comment.
Looks good! Added a few suggestions below
|
|
||
| ### ✅ Checklist | ||
| - [ ] I have tested the changes in this PR | ||
| - [ ] I confirmed whether my changes requires change in documentation and if so, I created another PR in MLRun for the relevant documentation. |
Member
There was a problem hiding this comment.
Suggested change
| - [ ] I confirmed whether my changes requires change in documentation and if so, I created another PR in MLRun for the relevant documentation. | |
| - [ ] I confirmed whether my changes require a change in documentation and if so, I created another PR in MLRun for the relevant documentation. |
Same below
| - [ ] I have tested the changes in this PR | ||
| - [ ] I confirmed whether my changes requires change in documentation and if so, I created another PR in MLRun for the relevant documentation. | ||
| - [ ] I confirmed whether my changes requires changes in QA tests, for example: credentials changes, resources naming change and if so, I updated the relevant Jira ticket for QA. | ||
| - [ ] I increase the Chart version in `charts/mlrun-ce/Chart.yaml`. |
Member
There was a problem hiding this comment.
Suggested change
| - [ ] I increase the Chart version in `charts/mlrun-ce/Chart.yaml`. | |
| - [ ] I increased the Chart version in `charts/mlrun-ce/Chart.yaml` (if applicable). |
|
|
||
| ### 🧪 Testing | ||
| <!-- - How it was tested (unit tests, manual, integration) --> | ||
| <!-- - Any special cases covered. --> |
Member
There was a problem hiding this comment.
Maybe add:
- [ ] Unit tests
- [ ] Manual testing (describe environment)
- [ ] Integration tests
Collaborator
Author
There was a problem hiding this comment.
In CE, we don’t include these tests. The requirement should be more general and allow users to describe their testing approach in a flexible way.
Comment on lines
+17
to
+18
| - [ ] I confirmed that the installation works both on a local Docker Desktop environment and on a real cluster when using the required [prerequisites](https://docs.mlrun.org/en/stable/install-mlrun-ce/kubernetes-install.html#prerequisites). | ||
| - [ ] If not, I updated the relevant Jira ticket with the installation issue and steps to reproduce it or update the prerequisites documentation if the issue is related to missing or outdated prerequisites. |
Member
There was a problem hiding this comment.
The nested checkbox structure under the installation item is a bit confusing imo, consider flattening them into two separate items:
Suggested change
| - [ ] I confirmed that the installation works both on a local Docker Desktop environment and on a real cluster when using the required [prerequisites](https://docs.mlrun.org/en/stable/install-mlrun-ce/kubernetes-install.html#prerequisites). | |
| - [ ] If not, I updated the relevant Jira ticket with the installation issue and steps to reproduce it or update the prerequisites documentation if the issue is related to missing or outdated prerequisites. | |
| - [ ] I confirmed that the installation works both on a local Docker Desktop environment and on a real cluster when using the required [prerequisites](https://docs.mlrun.org/en/stable/install-mlrun-ce/kubernetes-install.html#prerequisites). | |
| - [ ] If installation issues were found, I updated the relevant Jira ticket with the issue and steps to reproduce, or updated the prerequisites documentation if the issue is related to missing or outdated prerequisites. |
yaelgen
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.