Skip to content

Capture a moment only where the traveller checked in - #185

Merged
misabegovic merged 3 commits into
mainfrom
capture-needs-a-visit
Oct 8, 2026
Merged

misabegovic merged 3 commits into
mainfrom
capture-needs-a-visit

Conversation

@misabegovic

@misabegovic misabegovic commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

A moment should mean the traveller was there. The product promises this when it introduces moments, and the explore page says "visit it, capture a moment". The code never checked, so anyone signed in could post a moment to any place.

Now a moment is saved only after a check-in at that place. A check-in is the button a traveller presses on a place, which works only within 100 m of it. A check-in on any of their plans counts. Before it, the moments panel still shows other travellers' moments but offers no upload.

The change is safe for what exists: the check runs only when a moment is created, so saved moments stay as they are. Guests keep the sign-in button they have today.

This pull request adds the decision page wiki/decisions/capture-needs-a-check-in.md and updates the feature inventory.

- Moment refuses to be created without a check-in at its place, on any
  plan; asked on create only, so a moment outlives its check-in
- The upload tile waits for the visit; a guest keeps the sign-in tile
- Message in both locales: mark the visit first
- Tests: the three that asserted the tile without a visit now assert the
  opposite, and tests that build a moment check in first
- Brain: decision capture-needs-a-check-in, features, domain, state
The public-product line is left as main has it, so this branch and the
tag filter branch no longer edit the same line.
@misabegovic
misabegovic marked this pull request as ready for review October 8, 2026 08:23
@misabegovic
misabegovic merged commit dce8ea0 into main Oct 8, 2026
1 check passed
misabegovic added a commit that referenced this pull request Oct 14, 2026
Brings in #183 to #185. The old curator moments test stays deleted with the
queue it covered; its one change from #185, a check-in before a moment is
built, now lives in the admin moments test, since a moment needs one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JEmikXtNoH7wAg6veTjbyT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant