Skip to content

Moments queue in the admin - #182

Merged
misabegovic merged 3 commits into
mainfrom
ccr-331a6442-nf8lzj
Oct 14, 2026
Merged

misabegovic merged 3 commits into
mainfrom
ccr-331a6442-nf8lzj

Conversation

@misabegovic

Copy link
Copy Markdown
Owner

Curators now moderate moments in the admin. The queue lists public moments only and opens on those waiting for a decision; a private moment is not found even by its link. Approve and Reject work in either direction, so an approved moment can come down and a rejected one can be approved later, and search follows each decision.

Nobody edits or deletes a moment there: the traveller owns it, and rejecting is how one comes down. Photos are streamed by the app behind the same curator gate, not through Avo's file field, which would hand out a signed storage link anyone holding it could open. The old curator queue is removed. This is slice 5 of wiki/initiatives/avo-admin-and-roles.md.


Generated by Claude Code

claude and others added 2 commits September 30, 2026 18:13
- Moment resource: public moments only, opening on those waiting
- Approve and Reject actions for curators, in either direction
- Photos streamed by the app behind the curator gate, never a blob url
- Remove the curator moments page, route, tests and locale keys
- Brain: Avo slice 5 build notes, moments pages updated
Brings in #183 to #185. The old curator moments test stays deleted with the
queue it covered; its one change from #185, a check-in before a moment is
built, now lives in the admin moments test, since a moment needs one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JEmikXtNoH7wAg6veTjbyT
@misabegovic
misabegovic marked this pull request as ready for review October 14, 2026 09:08
@misabegovic

Copy link
Copy Markdown
Owner Author

Brought up to date with main (#183 to #185) by a merge commit, so the branch was not force-pushed.

  • The old curator moments test stays deleted along with the queue it covered. Its one change from Capture a moment only where the traveller checked in #185, a check-in before a moment is built, moved into test/integration/admin_moments_test.rb, since a moment now needs one.
  • wiki/state.md keeps this PR's Admin and Curator lines and gains main's "Moments need a check-in" line.

Locally on the merged branch:

  • bin/rails test: 2462 runs, 0 failures, 0 errors.
  • bin/rails test:system: 69 runs, 0 failures.
  • RuboCop and erb_lint: clean.

Note for review: a moment has a photo attachment. Avo's attachments endpoint (Avo::AttachmentsController) is not behind AdminResource, so a curator could delete a moment's photo through it, as with the other resources. That gap predates this PR and gets its own fix.

🤖 Generated with Claude Code

# Conflicts:
#	app/assets/builds/tailwind.css
@misabegovic
misabegovic merged commit 131f173 into main Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants