Repository navigation
Run the system tests on every pull request - #183
Merged
Merged
Conversation
- bin/rails test skips test/system, so the 68 browser tests ran only by hand - New step: bin/rails test:system in headless Chrome, screenshots kept on failure - SimpleCov starts on COVERAGE alone: under CI=true the browser tests by themselves fell below the unit suite's threshold and failed the step - Brain: the CI section of the architecture overview
misabegovic
marked this pull request as ready for review
October 8, 2026 08:21
misabegovic
added a commit
that referenced
this pull request
Oct 14, 2026
Brings in #183 to #185. The old curator moments test stays deleted with the queue it covered; its one change from #185, a check-in before a moment is built, now lives in the admin moments test, since a moment needs one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JEmikXtNoH7wAg6veTjbyT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change that breaks what a traveller sees in the browser should fail the pull request, the same way a broken unit test does. The browser tests in
test/systemclick through the real pages (the deck, check-ins, moments), butbin/rails testskips them, so they only ran by hand.CI now runs them in headless Chrome after the unit tests, and keeps a screenshot of any test that fails. All 68 pass on main today, so the step starts green, and the app code is untouched. If a test turns out flaky, the screenshot shows why, and the test is fixed rather than skipped.
The coverage check needed one fix. It fails a run when tests exercise less than 80% of the code, which suits the unit tests. It also ran for the browser tests, which cover far less, and failed them. It now runs only for the unit tests, at the same 80%.
The CI section of the architecture overview is updated to match.