Skip to content

Run the system tests on every pull request - #183

Merged
misabegovic merged 1 commit into
mainfrom
system-tests-in-ci
Oct 8, 2026
Merged

misabegovic merged 1 commit into
mainfrom
system-tests-in-ci

Conversation

@misabegovic

@misabegovic misabegovic commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

A change that breaks what a traveller sees in the browser should fail the pull request, the same way a broken unit test does. The browser tests in test/system click through the real pages (the deck, check-ins, moments), but bin/rails test skips them, so they only ran by hand.

CI now runs them in headless Chrome after the unit tests, and keeps a screenshot of any test that fails. All 68 pass on main today, so the step starts green, and the app code is untouched. If a test turns out flaky, the screenshot shows why, and the test is fixed rather than skipped.

The coverage check needed one fix. It fails a run when tests exercise less than 80% of the code, which suits the unit tests. It also ran for the browser tests, which cover far less, and failed them. It now runs only for the unit tests, at the same 80%.

The CI section of the architecture overview is updated to match.

- bin/rails test skips test/system, so the 68 browser tests ran only by hand
- New step: bin/rails test:system in headless Chrome, screenshots kept on failure
- SimpleCov starts on COVERAGE alone: under CI=true the browser tests by
  themselves fell below the unit suite's threshold and failed the step
- Brain: the CI section of the architecture overview
@misabegovic
misabegovic marked this pull request as ready for review October 8, 2026 08:21
@misabegovic
misabegovic merged commit c1c4fbb into main Oct 8, 2026
1 check passed
misabegovic added a commit that referenced this pull request Oct 14, 2026
Brings in #183 to #185. The old curator moments test stays deleted with the
queue it covered; its one change from #185, a check-in before a moment is
built, now lives in the admin moments test, since a moment needs one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JEmikXtNoH7wAg6veTjbyT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant