Skip to content

Keep IP address status under system control #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotwells merged 1 commit into from
Oct 2, 2026
Merged

Keep IP address status under system control #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion config/components/iam/protected-resources/ipallocation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@ spec:
- update
- patch
- delete
- updateStatus
subresources:
- name: status
permissions:
- get
- update
- patch
parentResources:
- apiGroup: resourcemanager.miloapis.com
kind: Project
7 changes: 6 additions & 1 deletion config/components/iam/protected-resources/ipclaim.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@ spec:
- update
- patch
- delete
- updateStatus
subresources:
- name: status
permissions:
- get
- update
- patch
parentResources:
- apiGroup: resourcemanager.miloapis.com
kind: Project
7 changes: 6 additions & 1 deletion config/components/iam/protected-resources/ipclass.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,16 @@ spec:
- update
- patch
- delete
- updateStatus
# "use" is checked when an IPClass in another project is created with
# spec.source naming this class (see internal/access/class.go). Granting it
# admits that project's claims into this class's address space.
- use
subresources:
- name: status
permissions:
- get
- update
- patch
parentResources:
- apiGroup: resourcemanager.miloapis.com
kind: Project
7 changes: 6 additions & 1 deletion config/components/iam/protected-resources/ippool.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,16 @@ spec:
- update
- patch
- delete
- updateStatus
# "use" is the verb checked by the IPAM PoolAccessChecker (see
# internal/access/sar.go) when a consumer claims from a shared pool.
# Granting it on a pool implicitly authorises cross-project allocation.
- use
subresources:
- name: status
permissions:
- get
- update
- patch
parentResources:
- apiGroup: resourcemanager.miloapis.com
kind: Project
7 changes: 1 addition & 6 deletions config/components/iam/roles/ipam-admin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ spec:
launchStage: Beta
# Admin is the union of provider (pool CRUD + use) and consumer (claim CRUD),
# both of which inherit viewer (reads). On top it adds full management of the
# system-created IPAllocation records and the status subresource on every
# resource type.
# system-created IPAllocation records. Status remains system-managed.
inheritedRoles:
- name: ipam.miloapis.com-provider
- name: ipam.miloapis.com-consumer
Expand All @@ -19,7 +18,3 @@ spec:
- ipam.miloapis.com/ipallocations.update
- ipam.miloapis.com/ipallocations.patch
- ipam.miloapis.com/ipallocations.delete
- ipam.miloapis.com/ipclasses.updateStatus
- ipam.miloapis.com/ippools.updateStatus
- ipam.miloapis.com/ipclaims.updateStatus
- ipam.miloapis.com/ipallocations.updateStatus
Loading