Repository navigation
Keep IP address status under system control - #132
Merged
Merged
Conversation
scotwells
marked this pull request as ready for review
October 2, 2026 15:06
JoseSzycho
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address allocation status remains system-managed when subresource authorization is enabled. Customers keep their existing pool, class, claim, and allocation management permissions, including reading observed status through normal resource reads, without access to IPAM
/statusendpoints.Declares all four served status subresources and removes the unused
updateStatuspermissions and admin grants. Repository-wide inspection found no request consumers of those legacy verbs. Admin, Provider, Consumer, and Viewer inheritance is otherwise unchanged.Depends on milo-os/milo#824 and milo-os/openfga-provider#139. Install the schema and declarations, then converge the provider manager before enabling webhook enforcement. The feature remains off by default; this PR does not enable it.
Validation: Milo integration, ProtectedResource, Role, and base deployment Kustomize builds passed. Semantic assertions matched the four registered API status routes, checked all four effective customer roles, and confirmed all non-status permissions are unchanged. No cluster changes.
Tracking issue: milo-os/milo#456