chore: remove excluded FilterModels UI and inventory exemptions - #206
Merged
Merged
Conversation
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old FilterModels WPF window is excluded from every supported build but still lives in the source inventory with two allowlist exemptions. Delete its three files, commented project entries and stale window references. Keep the reachable FilterModels.COMPANY compatibility command, its current logging/return values and all panel/palette bindings.
Closes #203. This removes 372 lines and adds 3 across 8 files, within the normal review limit. The separate private-helper follow-up is #204 on Project 3.
Mechanical verification: evaluated MSBuild Compile/Page identities are identical before/after for Release2024/2025/2026/2027 x64 (222 Compile, 0 Page). The entire compiled FilterNavisModels.cs source is identical after removing comments and blank lines: normalized SHA256 cebc6c58683310248f05c7f237eafddbaa7dd023876982232c116aa2408f269f. All 31 current plugin registrations remain; active references to the deleted window are zero, and the compile allowlist now has zero exemptions. The stale current README count of 30 was replaced with the inventory-guard link in EN/RU; dated release verification snapshots remain historical.
Final clean SHA 727185f passed all four SDK x64 builds. CI passed all 2358 cases with zero skips and confirmed 222 tracked/compiled C# files, zero exceptions and 31 Plugin attributes: https://github.com/mikhalchankasm/NavisWorksMaster/actions/runs/37188431277 . No compiled UI/runtime behavior changes or L3 claim; no tests added for deleted non-compiled code.