chore: remove unreachable FilterModels private helpers - #207
Merged
mikhalchankasm merged 2 commits intoOct 4, 2026
Merged
Conversation
This was referenced Oct 4, 2026
…-filter-helpers-20261004
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FilterModelsPlugin retained five private helper methods after its old UI was disabled. Execute calls none of them; only ProcessModelItem and CollectItemsToHide have self-recursive edges. Remove exactly those five unreachable methods and their unused imports, leaving the registered FilterModels.COMPANY command intact.
Closes #204. Follow-up to #206, intentionally separated to keep this review at one file and 132 deleted lines.
Mechanical verification: the five-method call graph has no edge from Execute; its only remaining edges are the two self-recursions. The normalized Execute body and Plugin/AddInPlugin attributes are identical before/after (Execute SHA256 12698fbc85dde068b4cd69891894b4ef6bf295d6931ff0c359def8dcbf767efa). No other compiled source refers to FilterModelsPlugin. Logging, return values, resource keys and existing panel/palette bindings are unchanged.
An unrelated CI caller-thread race was isolated and fixed in #209, then integrated from main. Final clean SHA ff3e24b passed Release2024/2025/2026/2027 x64 L2. Both fresh CI runs passed (37189874529 / 37189871493), including the full suite and all guards. No runtime behavior change or L3 claim; no behavior-mirroring tests added for unreachable deletion.