Skip to content

Fix core Messages test after API refactor #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikea merged 1 commit into from
Mar 29, 2026
Merged

Fix core Messages test after API refactor #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/core/test/messages.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,18 @@ import { describe, expect, it } from "vitest";
import { Messages } from "../src/messages.ts";

describe("Messages", () => {
it("is iterable and supports in-place replacement", () => {
it("is iterable and supports replacing the internal array in-place", () => {
const first: ModelMessage = { role: "user", content: "first" };
const second: ModelMessage = { role: "assistant", content: "second" };

const messages = new Messages();
messages.push(first, second);
const messages = new Messages([first]);
messages.pushAll([second]);

expect([...messages]).toEqual([first, second]);
expect(messages.slice(1)).toEqual([second]);
expect(messages.get().slice(1)).toEqual([second]);

messages.replace([second]);
const replacement = [second];
messages.get().splice(0, messages.length, ...replacement);

expect(messages.length).toBe(1);
expect([...messages]).toEqual([second]);
Expand Down
Loading