Fix core Messages test after API refactor#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Messageshelper API was refactored to use array-backed construction andpushAll/get()access, which caused the existing test to call removed methods and fail; the test was updated to match the new API while preserving the original behavioral assertions.Description
packages/core/test/messages.test.tsto constructMessageswith an initial array and append withpushAll(...)instead of the removedpush(...)usage.replace(...)/slice(...)assertions with in-place mutation viamessages.get().splice(...)andmessages.get().slice(...)to verify the same in-place replacement behavior against the new API.replacing the internal array in-place).Testing
pnpm --filter @piccolo/core testand the test suite for@piccolo/corepassed (all tests green).pnpm -r testand they passed (all projects/tests green).pnpm check(type/lint checks) and it completed successfully.Codex Task