feat(mobile): person detail screen with tappable cast (#32)#36
Merged
Merged
Conversation
Make cast members tappable: tapping one opens a person page showing their photo, bio, and filmography split into Acting and Directing/Crew. Titles in the filmography open their media detail, all within the current tab. - api: GET /tmdb/person/:personId (person + combined_credits), new to-person-detail mapper (movie/tv only, poster-filtered, de-duplicated, sorted by popularity/recency, normalized to the shared summary shape) - mobile: lib wrapper, tmdbKeys.person, usePersonDetail hook - mobile: personDetailHref + person/[id] routes in all four tab stacks; useMediaRouteBase now also resolves the insights tab - mobile: PersonDetail screen (parallax photo header, reused expandable bio, two filmography shelves), cast avatars navigate with a tap haptic - i18n: person.biography/acting/crew (EN/FR) - whats-new: "Cast & Crew Pages" release Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32. Part of epic #34.
What
Cast members become tappable. Tapping one opens a person page with photo, bio, and a filmography split into Acting and Directing & Crew. Filmography titles open their media detail — all within the current tab's back stack.
Changes
GET /tmdb/person/:personId(person +combined_creditsin one call). New pureto-person-detailmapper: movie/tv only, normalized via the sharednormalizeSummary, poster-filtered, de-duplicated bymedia_type:id, sorted by popularity then recency. Staticpersonsegment is matched ahead of/:mediaType/:tmdbId.lib/tmdb/person.ts,tmdbKeys.person,usePersonDetail.personDetailHref(personId, name, base)+ thinperson/[id]route in all four tab stacks (search, watchlist, profile, insights);useMediaRouteBasenow also resolvesinsights.PersonDetail— parallax photo header, reused expandable bio (OverviewSectionnow takes an optional title), two filmography shelves (Shelf + PosterCard).hapticTap;basethreaded from media & episode detail.person.*(EN/FR). What's New: "Cast & Crew Pages".Verification
bun run typecheck,bun run lint,bun run format:checkpass.🤖 Generated with Claude Code