feat: land person detail (#32) + in-app recommendations (#33) on dev#38
Merged
Conversation
Make cast members tappable: tapping one opens a person page showing their photo, bio, and filmography split into Acting and Directing/Crew. Titles in the filmography open their media detail, all within the current tab. - api: GET /tmdb/person/:personId (person + combined_credits), new to-person-detail mapper (movie/tv only, poster-filtered, de-duplicated, sorted by popularity/recency, normalized to the shared summary shape) - mobile: lib wrapper, tmdbKeys.person, usePersonDetail hook - mobile: personDetailHref + person/[id] routes in all four tab stacks; useMediaRouteBase now also resolves the insights tab - mobile: PersonDetail screen (parallax photo header, reused expandable bio, two filmography shelves), cast avatars navigate with a tap haptic - i18n: person.biography/acting/crew (EN/FR) - whats-new: "Cast & Crew Pages" release Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Recommend a movie or show to people you follow, with an optional note. Recipients get a push, find it in a dedicated "Received" inbox (with a bell + badge in the profile header), and tap through to the title. - db: new media_recommendations table (sender, recipient, media snapshot, message, readAt) + migration 0015 - api: new /media-recommendations module (send fan-out + per-recipient push, received inbox, mark-read, unread-count, recommendable-friends = people you follow, one-directional) - push: media-recommendation.received type + deep-link to the inbox - mobile: service handlers, query-key factory, send/received/unread hooks - mobile: send sheet (multi-select friends + optional message) opened from a media-detail header button; "Received" inbox marks entries read on view and opens the title; profile header bell + badge - i18n: recommend.* (EN/FR) - whats-new: "Recommend to Friends" release Run `bun run db:migrate` to apply the new table. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands #32 (person detail) and #33 (in-app media recommendations) onto
dev.Why this PR exists
The original PRs were stacked: #35 (#31) → #36 (#32) → #37 (#33). When all three were merged, only #35 landed on
dev— #36 merged into the #31 branch and #37 into the #32 branch, so #32 and #33 never reacheddev. This PR cherry-picks those two commits cleanly on top ofdev(which already has #31).Contents
9a764b8feat(mobile): person detail screen with tappable cast (feat(mobile): person detail screen (actor/crew filmography) #32)df95677feat: in-app media recommendations (feat: in-app media recommendations (recommend a movie to a friend) #33)(The
fix: lintcommit from the old branch — only.turbologs +app.json— was intentionally left out.)Run
bun run db:migrateto create themedia_recommendationstable (migration0015_giant_wong.sql).Verification
bun run typecheck+bun run lintpass on this branch.🤖 Generated with Claude Code