Skip to content

NVX Phase 1: Minimal Signed MicroVM integration - #1528

Open
Huzaifa Danish (huzaifa-d) wants to merge 18 commits into
mainfrom
user/modanish/nvx-phase1-signed-integration
Open

Huzaifa Danish (huzaifa-d) wants to merge 18 commits into
mainfrom
user/modanish/nvx-phase1-signed-integration

Conversation

@huzaifa-d

@huzaifa-d Huzaifa Danish (huzaifa-d) commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

📖 Description

Phase 1 of the NVX integration stack.
Replace the active Nanvix integration with the minimum Windows x64 NVX captured create-and-run path, behind the existing microvm feature.

Phase 1 Image limitation: The workload image is fixed to mcr.microsoft.com/azurelinux/base/core:3.0. Requests cannot select another image. This is temporary and handled in phase two.

🔗 References

Part of #1586.

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task

GitHub Actions runs the PR validation build automatically. The ADO pipeline
(MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHub
Actions build; it runs on merge to main, and Microsoft reviewers with write access can trigger it
on a PR with /azp run. See pull request builds.

If the dependency-feed-check check fails on a new dependency, the crate must be added to
the feed before the PR can pass. See pull request builds
for the steps.

Microsoft Reviewers: Open in CodeFlow

Add the minimal signed create-and-run NVX0430 bundle.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: aee99423-dfee-4d61-86e9-421b944c4cc0
Copilot AI balanced review requested due to automatic review settings October 19, 2026 17:58
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

This comment was marked as resolved.

Preserve executor output bytes and propagate test failures. Correct timeout assertions and simplify review wording and documentation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
huzaifa-msft and others added 2 commits October 19, 2026 12:52
Link the root README to the SDK integration notes and document host prerequisites and policy restrictions there.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Restore the Nanvix guide unchanged from the PR base and keep the README and CI notes focused on the current integration.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 19, 2026 21:59

This comment was marked as resolved.

@huzaifa-d
Huzaifa Danish (huzaifa-d) marked this pull request as ready for review October 20, 2026 18:07
@huzaifa-d
Huzaifa Danish (huzaifa-d) requested a review from a team as a code owner October 20, 2026 18:07
@huzaifa-d Huzaifa Danish (huzaifa-d) changed the title NVX phase 1: minimal signed MicroVM integration NVX phase 1: Minimal Signed MicroVM integration Oct 20, 2026
@huzaifa-d Huzaifa Danish (huzaifa-d) changed the title NVX phase 1: Minimal Signed MicroVM integration NVX Phase 1: Minimal Signed MicroVM integration Oct 20, 2026
huzaifa-msft and others added 5 commits October 21, 2026 16:08
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove unpublished Rust dependencies, retain pinned bundle verification, and validate packaging and explicit MicroVM CI execution.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 22, 2026 01:49

This comment was marked as resolved.

Enforce the combined 64 MiB output budget with cancellation and cleanup, validate process limits before bundle discovery, and validate the mapped native request before provisioning. Cover boundaries and cleanup through runtime and signed-bundle scenarios.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 22, 2026 21:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Native loading and VM teardown require human review, particularly while functional CI fails during startup and diagnostic preservation remains unresolved.

1 open issue
3 resolved since last review

Review effort: Balanced

Comment thread src/mxc-sdk/src/backends/nvx/runner.rs
Comment thread docs/schema.md Outdated
Comment thread docs/schema.md Outdated
Comment thread docs/schema.md Outdated
Comment thread src/mxc-sdk/build/build_nvx_bundled.rs
Comment thread src/mxc-sdk/build/build_nvx_bundled.rs
Address SDK test integration, backend documentation placement, and signed bundle maintenance feedback. Preserve the microvm feature name and Windows x64 Phase1 scope.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 18:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The native integration and VM ownership paths need final human review and Windows x64 validation, with unresolved cancellation and package-test issues.

3 open issues

Review effort: Balanced

Comment thread src/mxc-sdk/src/backends/nvx/runner.rs
Comment thread src/mxc-sdk/tests/nvx_e2e.rs Outdated
Comment thread src/mxc-sdk/README.md Outdated
Comment thread README.md
Comment thread src/mxc-sdk/src/backends/nvx/policy.rs
Comment thread src/mxc-sdk/src/backends/nvx/policy.rs
Comment thread src/mxc-sdk/src/backends/nvx/runner.rs
Comment thread src/mxc-sdk/src/backends/nvx/runner.rs
Comment thread src/mxc-sdk/src/core/mxc_engine/mod.rs Outdated
Comment thread src/mxc-sdk/src/core/mxc_engine/mod.rs Outdated
Comment thread src/mxc-sdk/src/core/mxc_common/models.rs Outdated
Comment thread src/mxc-sdk/src/core/mxc_common/models.rs Outdated
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs-Author-Feedback Waiting for additional information or action from the issue or pull-request author. label Oct 26, 2026
huzaifa-msft and others added 4 commits October 26, 2026 15:21
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…lation

Share captured and streaming invocation orchestration while retaining their distinct execution contracts. Capture bounded signed-agent diagnostics before teardown and route console interruption through native execution cancellation and ordered cleanup. Cover cancellation races and real console interruption during startup and silent execution.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Release bundle packaging remains incomplete, and native VM lifecycle and cancellation need final human review with Windows x64 validation evidence.

1 open issue
3 resolved since last review

Review effort: Balanced

Comment thread .github/workflows/Build.Windows.Job.yml
Keep native-only ProcessContainer and the updated CI log interface while retaining NVX cancellation, policy rejection, and nightly coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 23:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The native runtime replacement and cancellation guarantees need final human review backed by Windows x64 Hypervisor Platform execution and teardown results.

1 open issue

Review effort: Balanced

Restore the exact adapters and normalized models to main. Ignore legacy fallback settings consistently, with equivalent-policy and real executor/facade coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 27, 2026 00:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Native runtime integration, console interruption, and VM cleanup require final human review backed by successful validation on a Windows x64 host with Windows Hypervisor Platform enabled.

1 open issue

Review effort: Balanced

Preserve the complete pinned runtime in release ZIPs and VPack without re-signing. Exclude the unsupported MicroVM payload from npm with a scoped package rule and cover copy, ZIP hashes, missing inputs, and actual npm tarball contents.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 27, 2026 00:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Native VM execution, cancellation cleanup, and signed-bundle deployment require verified Windows x64 host results and final human review.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs-Author-Feedback Waiting for additional information or action from the issue or pull-request author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants