-
Notifications
You must be signed in to change notification settings - Fork 194
Clean up GitOps workflows and policies #1986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
flanakin
wants to merge
3
commits into
dev
Choose a base branch
from
flanakin/gitops-cleanup
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,97 +1,118 @@ | ||
| # Lines starting with '#' are comments. | ||
| # Each line is a file pattern followed by one or more owners. | ||
| # Lines starting with '#' are comments | ||
|
|
||
| # Each line is a file pattern followed by one or more owners | ||
|
|
||
| # More details are here: https://help.github.com/articles/about-codeowners/ | ||
|
|
||
| # The '*' pattern is global owners. | ||
| # The '\*' pattern is global owners | ||
|
|
||
| # Order is important. The last matching pattern has the most precedence | ||
|
|
||
| # The folders are ordered as follows | ||
|
|
||
| # Order is important. The last matching pattern has the most precedence. | ||
| # The folders are ordered as follows: | ||
| # In each subsection folders are ordered first by depth, then alphabetically | ||
|
|
||
| # In each subsection folders are ordered first by depth, then alphabetically. | ||
| # This should make it easy to add new rules without breaking existing ones. | ||
| # This should make it easy to add new rules without breaking existing ones | ||
|
|
||
| # Global rule | ||
| #* @microsoft/finops-toolkit | ||
| * @flanakin @arthurclares | ||
|
|
||
| # \* @microsoft/finops-toolkit | ||
|
|
||
| - @flanakin @msbrett | ||
|
|
||
| # DevOps folders | ||
| #.build @TODO | ||
| #.github @TODO | ||
| #docs-wiki @TODO | ||
| #src/scripts @TODO | ||
|
|
||
| # .build @TODO | ||
| # .github @TODO | ||
| # docs-wiki @TODO | ||
| # src/scripts @TODO | ||
|
|
||
| # General | ||
| #docs/help.md @TODO | ||
| #docs/README.md @TODO | ||
| #docs-mslearn/toolkit/help @TODO | ||
| #docs-mslearn/toolkit/*.md @TODO | ||
| #docs-wiki @TODO | ||
|
|
||
| # docs/help.md @TODO | ||
| # docs/README.md @TODO | ||
| # docs-mslearn/toolkit/help @TODO | ||
| # docs-mslearn/toolkit/\*.md @TODO | ||
| # docs-wiki @TODO | ||
|
|
||
| # FTK governing board | ||
|
|
||
| docs-mslearn/toolkit/roadmap.md @microsoft/finops-toolkit-board | ||
| docs-wiki/Advisory-council.md @microsoft/finops-toolkit-board | ||
| docs-wiki/Governing-board.md @microsoft/finops-toolkit-board | ||
| docs-wiki/Release-process.md @microsoft/finops-toolkit-board | ||
|
|
||
| # FTK advisory council | ||
|
|
||
| .github/CODEOWNERS @microsoft/finops-toolkit-council | ||
| docs-wiki/Coding-guidelines.md @microsoft/finops-toolkit-council | ||
| docs-wiki/Dev-process.md @microsoft/finops-toolkit-council | ||
| docs-wiki/Support-escalations.md @microsoft/finops-toolkit-board | ||
|
|
||
| # Alerts | ||
| docs/alerts.md @ro100e @arthurclares @flanakin | ||
| docs-mslearn/toolkit/alerts @ro100e @arthurclares @flanakin | ||
| src/templates/finops-alerts @ro100e | ||
|
|
||
| # docs/alerts.md @ro100e @flanakin | ||
| # docs-mslearn/toolkit/alerts @ro100e @flanakin | ||
| # src/templates/finops-alerts @ro100e @flanakin | ||
|
|
||
| # Bicep | ||
| #docs/bicep.md @TODO | ||
| #docs-mslearn/toolkit/bicep-registry @TODO | ||
| #src/bicep-registry @TODO | ||
|
|
||
| # docs/bicep.md @TODO | ||
| # docs-mslearn/toolkit/bicep-registry @TODO | ||
| # src/bicep-registry @TODO | ||
|
|
||
| # Guide | ||
| docs/guide.md @flanakin | ||
| docs-mslearn/best-practices @arthurclares @flanakin | ||
| docs-mslearn/framework @arthurclares @flanakin @kevindlr | ||
| docs-mslearn/focus @flanakin | ||
|
|
||
| #docs/guide.md @flanakin | ||
| #docs-mslearn/best-practices @arthurclares @flanakin | ||
| #docs-mslearn/framework @arthurclares @flanakin @kevindlr | ||
| #docs-mslearn/focus @flanakin | ||
|
|
||
| # Fabric | ||
| docs-mslearn/fabric @flanakin | ||
|
|
||
| #docs-mslearn/fabric @flanakin | ||
|
|
||
| # Hubs | ||
| docs/hubs.md @msbrett @flanakin @arthurclares | ||
| docs-mslearn/toolkit/hubs @msbrett @flanakin @arthurclares | ||
| src/templates/finops-hub @msbrett @flanakin @arthurclares | ||
|
|
||
| docs/hubs.md @msbrett @flanakin @RolandKrummenacher | ||
| docs-mslearn/toolkit/hubs @msbrett @flanakin @RolandKrummenacher | ||
| src/templates/finops-hub @msbrett @flanakin @RolandKrummenacher | ||
|
|
||
| # Open data | ||
| docs/open-data.md @flanakin | ||
| docs-mslearn/toolkit/open-data.md @flanakin | ||
| src/open-data @flanakin | ||
|
|
||
| #docs/open-data.md @flanakin | ||
| #docs-mslearn/toolkit/open-data.md @flanakin | ||
| #src/open-data @flanakin | ||
|
|
||
| # Optimization Engine | ||
| docs/optimization-engine.md @helderpinto @arthurclares @flanakin | ||
| docs-mslearn/toolkit/optimization-engine @helderpinto @arthurclares @flanakin | ||
|
|
||
| docs/optimization-engine.md @helderpinto @msbrett @flanakin | ||
| docs-mslearn/toolkit/optimization-engine @helderpinto @msbrett @flanakin | ||
| src/optimization-engine @helderpinto | ||
|
|
||
| # Power BI | ||
| #docs/power-bi.md @TODO | ||
| #docs-mslearn/toolkit/power-bi @TODO | ||
| #src/power-bi @TODO | ||
| src/power-bi/*/Governance* @nteyan | ||
|
|
||
| # docs/power-bi.md @TODO | ||
| # docs-mslearn/toolkit/power-bi @TODO | ||
| # src/power-bi @TODO | ||
| src/power-bi/storage/Governance.* @nteyan | ||
| src/power-bi/kql/Governance.* @nteyan | ||
|
|
||
| # PowerShell | ||
| #docs/powershell.md @TODO | ||
| #src/powershell @TODO | ||
| #docs-mslearn/toolkit/powershell @TODO | ||
| #src/powershell @TODO | ||
|
|
||
| # docs/powershell.md @TODO | ||
| # src/powershell @TODO | ||
| # docs-mslearn/toolkit/powershell @TODO | ||
| # src/powershell @TODO | ||
|
|
||
| # Web | ||
| src/web @ivanmtta @jamelachahbar @flanakin | ||
|
|
||
| src/web @jamelachahbar @flanakin @akiskips | ||
|
|
||
| # Workbooks | ||
|
|
||
| docs/workbooks.md @arthurclares @nteyan @flanakin | ||
| docs-mslearn/toolkit/workbooks @arthurclares @nteyan @flanakin | ||
| src/templates/finops-workbooks @arthurclares @nteyan | ||
| src/workbooks/governance @nteyan | ||
| src/workbooks/optimization @arthurclares | ||
| src/workbooks/optimization @arthurclares @flanakin | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CODEOWNERS entries must start with a file pattern (for the global rule this is typically
*). The current line starts with-, which will be treated as a literal path pattern and effectively breaks the intended global ownership rule.