Fix missing ParentInstanceID when creating a sub-orchestration by jeanmartins · Pull Request #131 · microsoft/durabletask-go

Jean Carlos Magalhães (jeanmartins) · 2026-05-04T15:44:50Z

Test evidence:

Jean Carlos Magalhães (jeanmartins) · 2026-05-04T15:48:03Z

@microsoft-github-policy-service agree

Copilot

Pull request overview

This PR updates the SQLite and PostgreSQL backends so sub-orchestration instances persist their ParentInstanceID into the Instances table, aligning runtime behavior with the existing schema and the linked issue about missing parent tracking.

Changes:

Capture ExecutionStarted.ParentInstance.OrchestrationInstance.InstanceId during instance creation.
Include ParentInstanceID in the INSERT statements for both SQLite and PostgreSQL backends.
Apply small Go formatting cleanups in backend/postgres/postgres.go.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
`backend/sqlite/sqlite.go`	Persists `ParentInstanceID` when inserting orchestration instances in SQLite.
`backend/postgres/postgres.go`	Persists `ParentInstanceID` when inserting orchestration instances in PostgreSQL and includes minor formatting cleanup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Chris Gillum (cgillum) · 2026-05-04T18:37:25Z

Jean Carlos Magalhães (@jeanmartins) Thanks for this PR! The changes look good to me, and I've approved the CI to run. I agree with Copilot that it would be good to have a test or two that validates the behavior, if you don't mind.

…ests for suborchestration with parent

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

… into develop

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Jean Carlos Magalhães (jeanmartins) · 2026-05-05T13:53:18Z

Hi Chris Gillum (@cgillum) , I added tests and also few changes to bring parent instance id in OrchestrationMetada, can you check please?

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.

…upstream

Jean Carlos Magalhães (jeanmartins) · 2026-05-07T00:04:57Z

Hi Chris Gillum (@cgillum) , I think everything look good now, could you review the changes please? Thanks!

Fix missing ParentInstanceID when creating a sub-orchestration

7790e26

Copilot AI review requested due to automatic review settings May 4, 2026 15:44

Jean Carlos Magalhães (jeanmartins) mentioned this pull request May 4, 2026

What is ParentInstanceID? #129

Open

Copilot started reviewing on behalf of Jean Carlos Magalhães (jeanmartins) May 4, 2026 15:47 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

Comment thread backend/sqlite/sqlite.go

Comment thread backend/postgres/postgres.go

JeanCarlos_MartinsDa and others added 2 commits May 4, 2026 19:59

added parentInstanceId into OrchestrationMetadata struct and create t…

c14e6b5

…ests for suborchestration with parent

Merge branch 'main' into develop

cb870cd

Copilot AI review requested due to automatic review settings May 4, 2026 23:00

Copilot started reviewing on behalf of Jean Carlos Magalhães (jeanmartins) May 4, 2026 23:02 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

Comment thread api/orchestration.go

Comment thread api/orchestration.go Outdated

Comment thread tests/metadata_test.go Outdated

JeanCarlos_MartinsDa added 3 commits May 4, 2026 20:13

fix issues found by copilot

dcd452d

Merge branch 'develop' of https://github.com/jeanmartins/durabletask-go…

eb84822

… into develop

fix copy issues with file

05ae430

Copilot AI review requested due to automatic review settings May 4, 2026 23:23

Copilot started reviewing on behalf of Jean Carlos Magalhães (jeanmartins) May 4, 2026 23:24 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

Comment thread backend/sqlite/sqlite.go Outdated

Comment thread backend/postgres/postgres.go Outdated

Comment thread api/orchestration.go

Potential fix for pull request finding

3bb466b

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 4, 2026 23:35

Copilot started reviewing on behalf of Jean Carlos Magalhães (jeanmartins) May 4, 2026 23:36 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

Comment thread api/orchestration.go

Comment thread backend/postgres/postgres.go

Comment thread tests/backend_test.go

Potential fix for pull request finding

505e0a2

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 5, 2026 00:18

Copilot started reviewing on behalf of Jean Carlos Magalhães (jeanmartins) May 5, 2026 00:19 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread backend/sqlite/sqlite.go

Comment thread backend/postgres/postgres.go

Comment thread backend/sqlite/sqlite.go

Comment thread api/orchestration.go

JeanCarlos_MartinsDa added 2 commits May 4, 2026 23:58

changes in OrchestrationMetada for parentinstanceid

e443fcb

fix checking for parenctInstance

f0562d4

Copilot AI review requested due to automatic review settings May 5, 2026 03:28

Copilot started reviewing on behalf of Jean Carlos Magalhães (jeanmartins) May 5, 2026 03:29 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread internal/protos/orchestrator_service.pb.go Outdated

Comment thread api/orchestration.go

Comment thread client/client_grpc.go

JeanCarlos_MartinsDa added 2 commits May 5, 2026 00:57

generate proto

7617a4b

check for parentinstanceid in metadata_test.go

a7a44b2

Chris Gillum (cgillum) requested a review from Copilot May 5, 2026 23:05

Copilot started reviewing on behalf of Chris Gillum (cgillum) May 5, 2026 23:06 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread vendored/durabletask-protobuf/protos/orchestrator_service.proto Outdated

Comment thread backend/executor.go

update proto

183d03c

Jean Carlos Magalhães (jeanmartins) requested a review from Copilot May 6, 2026 16:37

Copilot started reviewing on behalf of Jean Carlos Magalhães (jeanmartins) May 6, 2026 16:38 View session

Copilot AI reviewed May 6, 2026

View reviewed changes

add test

4435771

Jean Carlos Magalhães (jeanmartins) requested a review from Copilot May 6, 2026 16:51

Copilot started reviewing on behalf of Jean Carlos Magalhães (jeanmartins) May 6, 2026 16:52 View session

remove tests that does not makes sense since IGNORE was removed from …

198ef7e

…upstream

Jean Carlos Magalhães (jeanmartins) closed this May 28, 2026

Chris Gillum (cgillum) mentioned this pull request Jun 2, 2026

Fix missing ParentInstanceID when creating a sub-orchestration #133

Merged

Uh oh!

Conversation

Jean Carlos Magalhães (jeanmartins) commented May 4, 2026

Uh oh!

Jean Carlos Magalhães (jeanmartins) commented May 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Chris Gillum (cgillum) commented May 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jean Carlos Magalhães (jeanmartins) commented May 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Jean Carlos Magalhães (jeanmartins) commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants