Fix missing ParentInstanceID when creating a sub-orchestration - #133
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for persisting a parent orchestration instance reference when creating new orchestration instances in SQLite and Postgres backends.
Changes:
- Insert
ParentInstanceIDinto theInstancestable on orchestration start (SQLite + Postgres). - Minor Go formatting fixes in Postgres backend.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| backend/sqlite/sqlite.go | Extends instance insert to include ParentInstanceID derived from ExecutionStartedEvent.ParentInstance. |
| backend/postgres/postgres.go | Extends instance insert to include ParentInstanceID; also fixes minor formatting in a couple spots. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Hi Chris Gillum (@cgillum) , please review and approve when you have a moment. |
Chris Gillum (cgillum)
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this PR! I assume that there will be some follow-up work, similar to PR #131, which will complete the feature?
Issue: #129