Change from using xdg shell v5 to v6.#8
Conversation
Also fix shell return value detection.
|
Fixed issue for me. I'm using a custom compositor, but I believe this issue will impact all consumers of wlc May've fixed #4, but I haven't updated for awhile |
|
Good. Other parts of Velox should be fixed also. |
|
Thanks for this! I found that currently on my Intel machine I need to add the following patch on top of your commit otherwise I get a "xdg_surface has never been configured" error and st crashes: I found the solution to this issue here: https://patches.videolan.org/patch/20875/ |
|
@Shugyousha added that commit to the branch. Ran a quick test and it doesn't break anything, so . . . good enough for me. :-) |
|
Since the xdg shell protocol is currently stable, here is a commit to use the stable protocol, for those who care. This is necessary to use st on swc, for example, as it would segfault on anything but stable. |
As mentioned in #6 , sway uses zxdg v6, not xdg v5. I'm no expert in Wayland or xdg-shell, but from an hours' work poking around I managed to get st running on sway using zxdg v6. Seems to be working well, but I'd welcome some code review.
I'm not expecting this to be merged, but including a new branch with this support would be awesome.
Thanks!