Skip to content

Change from using xdg shell v5 to v6.#8

Open
etherealvisage wants to merge 4 commits into
michaelforney:waylandfrom
etherealvisage:wayland
Open

Change from using xdg shell v5 to v6.#8
etherealvisage wants to merge 4 commits into
michaelforney:waylandfrom
etherealvisage:wayland

Conversation

@etherealvisage

Copy link
Copy Markdown

As mentioned in #6 , sway uses zxdg v6, not xdg v5. I'm no expert in Wayland or xdg-shell, but from an hours' work poking around I managed to get st running on sway using zxdg v6. Seems to be working well, but I'd welcome some code review.

I'm not expecting this to be merged, but including a new branch with this support would be awesome.

Thanks!

@serprex

serprex commented Feb 26, 2017

Copy link
Copy Markdown

Fixed issue for me. I'm using a custom compositor, but I believe this issue will impact all consumers of wlc

May've fixed #4, but I haven't updated for awhile

@DmitryHetman

Copy link
Copy Markdown

Good. Other parts of Velox should be fixed also.

@Shugyousha

Copy link
Copy Markdown
Contributor

Thanks for this! I found that currently on my Intel machine I need to add the following patch on top of your commit otherwise I get a "xdg_surface has never been configured" error and st crashes:

diff --git a/st.c b/st.c
index d905620..8669b76 100644
--- a/st.c
+++ b/st.c
@@ -3421,6 +3421,8 @@ wlinit(void)
        zxdg_toplevel_v6_add_listener(wl.xdgtoplevel, &xdgtoplevellistener,
                NULL);

+       wl_surface_commit(wl.surface);
+
        wl.xkb.ctx = xkb_context_new(0);
        wlresettitle();
}

I found the solution to this issue here: https://patches.videolan.org/patch/20875/

@etherealvisage

Copy link
Copy Markdown
Author

@Shugyousha added that commit to the branch. Ran a quick test and it doesn't break anything, so . . . good enough for me. :-)

@ianbeyst

ianbeyst commented Jun 11, 2019

Copy link
Copy Markdown

Since the xdg shell protocol is currently stable, here is a commit to use the stable protocol, for those who care. This is necessary to use st on swc, for example, as it would segfault on anything but stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants