Wayland by ivucica · Pull Request #17 · gnustep/libs-back

ivucica · 2020-01-26T21:26:20Z

This includes contributions from Sergio L. Pascual and Ladislav Michl @3x380V. Both have performed copyright assignment to FSF.

This likely requires a rebase+merge of https://github.com/ivucica/libs-gui/tree/ivucica-wayland as well.

This currently does not run on my machine, as I'm hitting:

    if (!wlconfig->compositor || !wlconfig->wm_base) {
        [NSException raise: NSWindowServerCommunicationException
                    format: @"Unable to get compositor"];

Opening this PR for easier viewing anyway.

fredkiefer

I only glanced at this code but apart from minor issues I think we should merge it.

fredkiefer · 2020-03-06T17:36:53Z

+	if (window) {
+	    x += window->pos_x;
+	    y += window->pos_y;
+	    win = &window->window_id;


Check for win being NULL is missing.

Interestingly, it was not even writing into *win...

ivucica · 2020-04-05T14:26:09Z

I'll continue work on this after the next release.

non functional, all changes just make it compile again. Configure changes by Ivan Vučica.

For contributions, we generally ask that copyright is assigned to FSF. I believe this has been done by Sergio.

ivucica

I needed to enter this comment field for some reason...

Rearranging order of the code, freeing some memory, writing a note that additional work is required, returning a value through pointer passed as argument, etc.

ivucica · 2020-04-14T23:39:50Z

Sorry for the noise and presumably numerous emails. Github review UI was surprisingly not letting me comment directly in the pull request after I started a review; presumably I was supposed to write replies 'somewhere else'.

I think your comments are useful, so I am reluctant to just go ahead and merge as-is, thus losing the information in this then-merged PR.

I intended to run the code today, but I only got around to rebasing the code, and addressing the most superficial of problems you spotted. Thank you for looking at this in-depth; applying some fixes will be tricky as well, as I am new to Wayland and this new code. Perhaps soon.

ivucica · 2020-04-14T23:41:23Z

@slp It looks like I can't directly assign you this review (presumably because you were not added to the GH org, not sure).

However, your input is required for the changes to the headers. Has the copyright been assigned and may I change the headers as visible in my commits?

This now results in windows being painted on the screen. However, input is still ending up in all the wrong places, and there is a lot of garbage content being painted outside the actual windows. Right clicking on a window seems to trigger rotate behavior, which needs to be evaluated and likely removed (or prevented, if this is done by Weston). Interestingly, checking for ->configured on first surface commit also seems to break the backend.

ivucica · 2020-04-17T00:25:33Z

In 41b2d29 I managed to get stuff to paint by not committing the surface unless we first received a configure request and have acked it. Not doing this is against the protocol, and Weston actively drops the connection if we do this.

Only updating one location for wl_surface_commit(), the one in WaylandCairoSurface(), does the trick; in the other location, apparently we are supposed to commit this surface, even if unconfigured.

We still get a lot of garbage, and behavior is generally very broken when it comes to input and clicking around.

Here's SystemPreferences.app:

Here's Calculator.app:

ivucica · 2020-04-17T00:31:01Z

Some resources for understanding that commit:

weston's xdg-shell.c on line 1250
vlc discussion resolving similar issue
a somewhat related fix for st terminal emulator (albeit it's related only to a lesser extent)

… informative. The exception was not very informative about why exactly the error message may occur. Weston in Debian buster doesn't support the stable XDG Shell protocol, for instance, and triaging this took some effort.

…e memory.

… and for mouse wheel axis_source.

ivucica · 2020-04-25T17:26:58Z

@fredkiefer Would you like to take a final look at this before we merge this? As we agreed, we should merge it in its incomplete and broken state.

If you LGTM this, I'll rebase as necessary and push to the main branch, updating any dates as required. Let me know.

fredkiefer

We both agree as long as this does not break any other backend it is OK to merge, Hopefully someone will pick up the code from there.

ivucica requested a review from fredkiefer as a code owner January 26, 2020 21:26

ivucica removed the request for review from fredkiefer January 26, 2020 21:34

ivucica force-pushed the wayland-2 branch 3 times, most recently from faafc1a to 35b8355 Compare January 26, 2020 22:06

fredkiefer reviewed Mar 6, 2020

View reviewed changes

Sergio L. Pascual and others added 7 commits April 15, 2020 00:00

Dirty Wayland backend implementation.

8145620

wayland: Add wayland integration and use stable protocol.

05f362d

non functional, all changes just make it compile again. Configure changes by Ivan Vučica.

wayland: Whitespace fixes

e805a4a

wayland: Use memfd_create

4311a81

wayland: WIP

c1cce2a

wayland: Split the check for compositor and wm_base into two checks.

3db7a6f

wayland: Include a script for regenerating protocol headers/source.

24cbc5a

ivucica force-pushed the wayland-2 branch from 35b8355 to 24cbc5a Compare April 14, 2020 23:02

ivucica marked this pull request as draft April 14, 2020 23:10

wayland: Update license headers and copyright statement.

e8e6155

For contributions, we generally ask that copyright is assigned to FSF. I believe this has been done by Sergio.

ivucica commented Apr 14, 2020

View reviewed changes

ivucica added 2 commits April 15, 2020 00:35

wayland: Additional license header fixes noticed during PR.

80cc412

wayland: Assortment of fixes noticed during code review.

36eefc9

Rearranging order of the code, freeing some memory, writing a note that additional work is required, returning a value through pointer passed as argument, etc.

ivucica marked this pull request as ready for review April 14, 2020 23:37

ivucica added 4 commits April 25, 2020 16:14

wayland: Additional clean up for license headers.

359aa9e

wayland: Additional interface registration NSDebugLog() output.

84f71f5

wayland: Performed some investigation into freeing WaylandCairoSurfac…

de9a8b3

…e memory.

ivucica added 8 commits April 25, 2020 18:12

wayland: Remove the 'fake drawing' branch.

12f1d48

wayland: Support mouse middle click and smooth scroll wheel events.

c6e9ee8

wayland: Deleted the useless override of -[GSDisplayServer windowlist].

67e352b

wayland: Implement -[WaylandServer mouselocation].

f8b8609

wayland: Write down TODOs for cairo_surface doublebuffering to itself…

8f0cc1b

… and for mouse wheel axis_source.

wayland: Update the changelog for the merge.

2bbcb04

wayland: Added a small readme noting some backend-specific information.

bf4efe9

wayland: Mention the new README in the changelog.

4ab5a69

fredkiefer approved these changes Apr 25, 2020

View reviewed changes

ivucica merged commit 4ab5a69 into gnustep:master Apr 25, 2020

andyarvanitis mentioned this pull request Jul 7, 2020

Wayland support? trunkmaster/nextspace#239

Closed

Uh oh!

Conversation

ivucica commented Jan 26, 2020

Uh oh!

fredkiefer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fredkiefer Mar 6, 2020

Choose a reason for hiding this comment

Uh oh!

ivucica Apr 14, 2020

Choose a reason for hiding this comment

Uh oh!

ivucica commented Apr 5, 2020

Uh oh!

ivucica left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivucica commented Apr 14, 2020

Uh oh!

ivucica commented Apr 14, 2020

Uh oh!

ivucica commented Apr 17, 2020

Uh oh!

ivucica commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivucica commented Apr 25, 2020

Uh oh!

fredkiefer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

ivucica left a comment •

edited

Loading

ivucica commented Apr 17, 2020 •

edited

Loading