Skip to content

Enhanced examples#46

Merged
semohr merged 12 commits intomainfrom
enhanced_examples
Mar 15, 2026
Merged

Enhanced examples#46
semohr merged 12 commits intomainfrom
enhanced_examples

Conversation

@semohr
Copy link
Copy Markdown
Contributor

@semohr semohr commented Mar 1, 2026

Added a examples subpages to the docs and cleaned examples notebooks:

  • moved old examples into examples/old folder (they need another look)
  • migrated traktor to mp3 example
  • migrated top100dnb example to a more generic one directional sync example
  • removed exploration notebook

TODOs:

  • I would remove the notebooks folder and just use the examples folder going forward
  • Remove/Refactor or properly integrate old examples
  • More examples?
  • Tests are failing because of the get_playlist(name=...) inconsistency (None vs Raise) I think. Lets decide this and then fix it for all services.
  • Changelog

bases on #45
closes #32

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
plistsync/core/diff.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@semohr semohr force-pushed the enhanced_examples branch 2 times, most recently from 3a0caac to 8938872 Compare March 3, 2026 21:53
@semohr semohr force-pushed the main branch 5 times, most recently from adebd1a to e0e9b2f Compare March 7, 2026 21:26
@semohr semohr temporarily deployed to integration_tests March 8, 2026 16:23 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests March 8, 2026 16:23 — with GitHub Actions Inactive
@semohr semohr force-pushed the enhanced_examples branch from 9211852 to c753581 Compare March 8, 2026 16:23
@semohr semohr temporarily deployed to integration_tests March 8, 2026 16:23 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests March 8, 2026 16:23 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests March 8, 2026 17:51 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests March 8, 2026 17:51 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests March 10, 2026 15:36 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests March 10, 2026 15:36 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests March 10, 2026 21:26 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests March 10, 2026 21:26 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests March 10, 2026 21:27 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests March 10, 2026 21:27 — with GitHub Actions Inactive
@semohr
Copy link
Copy Markdown
Contributor Author

semohr commented Mar 11, 2026

Tests are failing because of the get_playlist(name=...) inconsistency (None vs Raise) I think. Lets decide this and then fix it for all services.

Let's not touch too much tests in this PR. I think we should move this discussion and the fixes into another one. There is alot going on here already. I think we can also unify quite some tests between services to enforce right implementations. Maybe that is also a good point to revisit the current setup.

@pSpitzner pSpitzner mentioned this pull request Mar 11, 2026
@pSpitzner pSpitzner added this to the v1.0.0 milestone Mar 13, 2026
@pSpitzner pSpitzner temporarily deployed to integration_tests March 13, 2026 13:59 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests March 13, 2026 13:59 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests March 13, 2026 15:47 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests March 13, 2026 15:47 — with GitHub Actions Inactive
@semohr semohr force-pushed the enhanced_examples branch from 11c342d to c31a541 Compare March 14, 2026 19:48
@semohr semohr temporarily deployed to integration_tests March 14, 2026 19:48 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests March 14, 2026 19:48 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests March 14, 2026 20:23 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests March 14, 2026 20:23 — with GitHub Actions Inactive
@semohr semohr force-pushed the enhanced_examples branch from a12497b to f96a335 Compare March 14, 2026 20:59
@semohr semohr temporarily deployed to integration_tests March 14, 2026 20:59 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests March 14, 2026 20:59 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests March 15, 2026 10:46 — with GitHub Actions Inactive
@pSpitzner pSpitzner temporarily deployed to integration_tests March 15, 2026 10:46 — with GitHub Actions Inactive
@pSpitzner
Copy link
Copy Markdown
Contributor

just added the changelog entry, and confirmed the docs build looks nice.

I think we can merge this now, if you dont see anything else?

@semohr
Copy link
Copy Markdown
Contributor Author

semohr commented Mar 15, 2026

Nope looks good to me too 👍

@semohr semohr merged commit 3d63e8b into main Mar 15, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework examples

2 participants