Added get_playlist_or_raise method to library base class.#67
Merged
Conversation
pSpitzner
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
pSpitzner
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
|
The author of this PR, pSpitzner, is not an activated member of this organization on Codecov. |
I considered adding them on service-level, to get the typing overloads. but this was a lot of code duplication (I would even consider to drop it for the get_playlist method, since we now have consistent return types for all overloads) Also removed the override decorator on get_playlist, because its an abstractmethod in the parent class.
pSpitzner
force-pushed
the
get_playlist_or_raise
branch
from
831fe42 to
54fae96
Compare
pSpitzner
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
pSpitzner
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
pSpitzner
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
pSpitzner
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
Contributor
Author
|
Had to cherry pick some other tweaks from #46 hopefully we dont get too many conflicts when rebasing Mypy issues are from the examples, fixed in the other PR |
semohr
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
semohr
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I considered adding them on service-level, to get the typing overloads. but this was a lot of code duplication (I would even consider to drop it for the get_playlist method, since we now have consistent return types for all overloads)
Also removed the override decorator on get_playlist, because its an abstractmethod in the parent class.