Skip to content

Improve ZIP handling and compatibility with upload pipeline #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VanshikaSabharwal wants to merge 3 commits into
base: master
Choose a base branch
from
+35 −16
Open

Improve ZIP handling and compatibility with upload pipeline #241

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7303cb3
fixed the type
VanshikaSabharwal Apr 15, 2026
a40f973
promisified and removed linting errors
VanshikaSabharwal Apr 17, 2026
0deb5af
promisified the data part only
VanshikaSabharwal Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 35 additions & 16 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

import { MetaCallJSON } from '@metacall/protocol/deployment';
import archiver, { Archiver } from 'archiver';
import archiver from 'archiver';
import { parse } from 'dotenv';
import { promises as fs } from 'fs';
import { prompt } from 'inquirer';
Expand Down Expand Up @@ -109,41 +109,60 @@ export const zip = async (
pulse?: (name: string) => void,
hide?: () => void,
ignorePatterns?: string[]
): Promise<Archiver> => {
// Apply ignore patterns
): Promise<Blob> => {
files = filterFiles(files, ignorePatterns);

const archive = archiver('zip', {
zlib: { level: 9 }
});

const chunks: Buffer[] = [];

if (progress) {
archive.on('progress', data =>
archive.on('progress', data => {
progress(
'Compressing and deploying...',
data.fs.processedBytes / data.fs.totalBytes
)
);
);
});
}

if (pulse) {
archive.on('entry', (entry: archiver.EntryData) => pulse(entry.name));
archive.on('entry', (entry: archiver.EntryData) => {
pulse(entry.name);
});
}

files = files.map(file => join(source, file));
const dataPromise = new Promise<Blob>((resolve, reject) => {
archive.on('data', (chunk: Buffer) => chunks.push(chunk));
archive.on('end', () => {
if (hide) {
archive.on('finish', () => hide());
}
resolve(
new Blob([Buffer.concat(chunks)], {
type: 'application/x-zip-compressed'
})
);
});
archive.on('error', reject);
});

const fullPaths = files.map(file => join(source, file));

for (const file of files) {
(await fs.stat(file)).isDirectory()
? archive.directory(file, basename(file))
: archive.file(file, { name: relative(source, file) });
}
for (const file of fullPaths) {
const stat = await fs.stat(file);

if (hide) {
archive.on('finish', () => hide());
if (stat.isDirectory()) {
archive.directory(file, basename(file));
} else {
archive.file(file, { name: relative(source, file) });
}
}

await archive.finalize();

return archive;
return dataPromise;
};

/**
Expand Down