Improve ZIP handling and compatibility with upload pipeline#241
Open
VanshikaSabharwal wants to merge 3 commits intometacall:masterfrom
Open
Improve ZIP handling and compatibility with upload pipeline#241VanshikaSabharwal wants to merge 3 commits intometacall:masterfrom
VanshikaSabharwal wants to merge 3 commits intometacall:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes I made:-
Reason:-
The archiver package does not return a native Node.js Readable stream. Instead, it extends readable-stream's Transform, which causes issues when passing it to the deployment protocol (e.g., instanceof Readable checks fail).
This resulted in incompatibility with the upload mechanism.
By buffering the archive output and returning it as a Blob, we ensure:
Working GitHub workflow Link:- https://github.com/VanshikaSabharwal/faas/actions/runs/24439286633/job/71400355463