Skip to content

Sheets: keep the Done row at its own height - #185

Closed
mblauberg wants to merge 1 commit into
mainfrom
lane/sheet-done
Closed

mblauberg wants to merge 1 commit into
mainfrom
lane/sheet-done

Conversation

@mblauberg

Copy link
Copy Markdown
Owner

Summary

The full UI matrix on 86307d0 had 2 failures in 275 runs: presets / two-mice / ax and presets / paused / ax found the sheet's Done button at 33 × 13 pt. With no presets, the ContentUnavailableView in PresetsSheet takes all the height on offer and squeezes the AdvancedSheet button row. That row now keeps its own height (fixedSize(vertical:)).

How checked

swift build. Still to do: rerun scripts/ui-matrix.sh --only presets on the workshop.

Footprint

None; Settings only.

Docs

None needed: a layout fix with no rule change.

Agent evidence

AX dump: AXButton "Done" 33x13 (two-mice) vs 48x20 (one-mouse, which has presets).

The presets sheet's empty state took every point offered, which squeezed
the Done row to 33 x 13 pt (ui-matrix presets / two-mice and paused, ax).
@mblauberg
mblauberg marked this pull request as draft November 4, 2026 01:42
@mblauberg

Copy link
Copy Markdown
Owner Author

Parked: this doesn't fix it. A rerun of ui-matrix --only presets on the branch still reports Done at 33×13 in all three fixtures. Captures show the shrink is intermittent and covers the whole sheet, not just the button row (the preset values and "DPI" render small too); one main run had Done at 48×20. Moving +/− out of the section footer didn't change it. The cause is still unknown; not blocking 0.6.0.

@mblauberg

Copy link
Copy Markdown
Owner Author

Tracked in #191.

@mblauberg

Copy link
Copy Markdown
Owner Author

Superseded: #191's cause was the tab cross-fade, fixed on main by #197 (7b97ed6). The experiments are in the closing comment on #191. Pinning the Done row's height didn't help.

@mblauberg mblauberg closed this Nov 4, 2026
@mblauberg
mblauberg deleted the lane/sheet-done branch November 4, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant