Repository navigation
Conversation
The presets sheet's empty state took every point offered, which squeezed the Done row to 33 x 13 pt (ui-matrix presets / two-mice and paused, ax).
mblauberg
marked this pull request as draft
November 4, 2026 01:42
Owner
Author
|
Parked: this doesn't fix it. A rerun of |
2 tasks
Owner
Author
|
Tracked in #191. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The full UI matrix on 86307d0 had 2 failures in 275 runs:
presets / two-mice / axandpresets / paused / axfound the sheet's Done button at 33 × 13 pt. With no presets, theContentUnavailableViewinPresetsSheettakes all the height on offer and squeezes theAdvancedSheetbutton row. That row now keeps its own height (fixedSize(vertical:)).How checked
swift build. Still to do: rerunscripts/ui-matrix.sh --only presetson the workshop.Footprint
None; Settings only.
Docs
None needed: a layout fix with no rule change.
Agent evidence
AX dump:
AXButton "Done" 33x13(two-mice) vs48x20(one-mouse, which has presets).