Skip to content

Presets sheet sometimes draws its controls small (Done at 33×13 pt) #191

Closed

Description

@mblauberg

Outcome

The Presets sheet (Mouse › Pointer › Edit Presets…) draws its controls at the normal size every time, with Done the same size as every other sheet's.

Evidence

  • scripts/ui-matrix.sh --only presets on the spare Mac (macOS 27.0.1): Done reads 33×13 pt in the AX dump. On main 8000f17 that was 2 of 3 fixtures (one-mouse read 48×20); on branch lane/sheet-done it was all 3. Every other sheet reads 48×20.
  • Onscreen captures of a debug build (5–10 s after opening) show the whole sheet's controls shrunk: Done, the preset values and "DPI", but not the "Preset" labels. One capture out of about six drew everything at full size.
  • Neither of these changed it: .fixedSize on AdvancedSheet's button row, or moving the +/− row out of the section footer into the leading slot. Draft PR Sheets: keep the Done row at its own height #185 records both.

Repro

Run scripts/ui-matrix.sh --only presets on the spare Mac, never this one (AGENTS.md hard rules). Look for PROBLEM … AXButton "Done" (33.0, 13.0) in presets.*.ax.txt.

Expected

Done at 48×20 like the other sheets, and the preset values at body size.

Acceptance

  • ui-matrix --only presets reports no findings in three consecutive runs. [command]
  • A light and a dark capture show Done, the values and "DPI" at the same size as in the Scrolling sheet. [capture]

Durable home

docs/ui-design.md (Implementation) if the cause is a SwiftUI rule worth keeping.

Activity

  1. mblauberg commented on Nov 4, 2026

    @mblauberg
    OwnerAuthor

    Fixed on main by #197, commit 7b97ed6, which sets transitionOptions = [] on the Settings tab controller. No further code change is needed.

    Cause

    • Observed: NSTabViewController ran a cross-fade ([.crossfade, .allowUserInteraction]) when the window first showed. SettingsWindow.show presented the Presets sheet on the next main-queue turn, while that cross-fade was still running.
    • Inferred: the sheet's controls resolved at the small size (Done measured 33×13). The AppKit mechanism wasn't isolated.
    • Only Presets is opened by a ShowRequest on that turn. The other sheets open from their pane's own onAppear, which is why only Presets was affected.

    Experiments on the spare Mac (scripts/ui-matrix.sh --only presets; each run covers the one-mouse, two-mice and paused fixtures)

    Variant Done size
    8000f17 (this issue), and 28b4d15 / b7f3c47 (before 7b97ed6) 33×13 in every run
    7b97ed6 and 914a2fb (#197) 48×20
    On 28b4d15 with transitionOptions = [] only 48×20
    On 28b4d15 with the Presets request delayed by 1 s 48×20
    On 28b4d15 with .bordered on Done, a plain-text empty state, a VStack wrapper plus .environment(model), or fitWindow(animated: false) 33×13

    Verification on main (ccc4316, an ancestor of 93b396b)

    • Three consecutive --only presets runs: 9 of 9 fixtures at 48×20, no problems.
    • The full matrix: 275 runs, 0 failed, 0 findings.
    • Not covered: a sheet with populated presets. The matrix only renders the empty state.

    Draft #185 targeted the wrong cause and is closed as superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions