ci: add dedicated Release benchmark app and performance reporting - #1583
Draft
mrousavy wants to merge 18 commits into
Draft
ci: add dedicated Release benchmark app and performance reporting#1583mrousavy wants to merge 18 commits into
mrousavy wants to merge 18 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 4, 2026
Member
Author
|
The version-alignment guard is isolated in #1584. Local validation also completed all 40 benchmark cases × 20 samples on the standalone iOS Release/Hermes app; the receiver validated release metadata and checksums. Full paired GitHub CI is running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Depends on #1582 (example move), which depends on #1585 (isolated Xcode compatibility fix). Version alignment stays in the separate follow-up #1584.
Summary
apps/benchmark: a minimal Release/Hermes app without Harness or navigation dependencies.apps/examplekeeps demos and Harness correctness tests.Validation
Rollout
The initial PR uses the head binary on both sides (A/A), because its base predates the benchmark app. It does not measure this PR versus main; the current BASE label/SHA on bootstrap A/A artifacts is misleading and still needs correction. The pre-merge publisher deliberately excludes these bootstrap runs. Later PRs, including #1588, build each revision independently and publish true paired results.
Verdicts remain advisory. Same-repository paired PR comments can publish now; fork reporting activates once
workflow_runis on main. Rotate the exposed credential before settingNITRO_BENCHER_ENABLED=true; no build/device job or fork job receives that secret. Bencher activation still awaits confirmation that the exposed credential has been replaced.Supersedes #1581.