Conversation
adrianriobo
approved these changes
Jun 12, 2026
adrianriobo
left a comment
adrianriobo
left a comment
Contributor
There was a problem hiding this comment.
LGMT, did not check I mainly read commit and quick check, all seems good
ppitonak
force-pushed
the
tkn_tasks
branch
3 times, most recently
from
784c94c to
1bbdbfd
Compare
Collaborator
Author
|
I tested destroy with AWS and it worked fine. |
XiyangDong
reviewed
Jun 12, 2026
XiyangDong
reviewed
Jun 12, 2026
| annotations: | ||
| tekton.dev/pipelines.minVersion: "0.44.x" | ||
| tekton.dev/categories: infrastructure | ||
| tekton.dev/tags: infrastructure, aws, rhelai |
XiyangDong
reviewed
Jun 12, 2026
| description: destroy even if there is a lock | ||
| default: "false" | ||
| - name: keep-state | ||
| description: keep the Pulumi state in the S3 backend after successful destroy |
XiyangDong
reviewed
Jun 12, 2026
| description: destroy even if there is a lock | ||
| default: "false" | ||
| - name: keep-state | ||
| description: keep the Pulumi state in the S3 backend after successful destroy |
XiyangDong
reviewed
Jun 12, 2026
| description: destroy even if there is a lock | ||
| default: "false" | ||
| - name: keep-state | ||
| description: keep the Pulumi state in the S3 backend after successful destroy |
XiyangDong
reviewed
Jun 12, 2026
| description: destroy even if there is a lock | ||
| default: "false" | ||
| - name: keep-state | ||
| description: keep the Pulumi state in the S3 backend after successful destroy |
XiyangDong
reviewed
Jun 12, 2026
| description: destroy even if there is a lock | ||
| default: "false" | ||
| - name: keep-state | ||
| description: keep the Pulumi state in the S3 backend after successful destroy |
XiyangDong
reviewed
Jun 12, 2026
| description: destroy even if there is a lock | ||
| default: "false" | ||
| - name: keep-state | ||
| description: keep the Pulumi state in the S3 backend after successful destroy |
XiyangDong
approved these changes
Jun 12, 2026
XiyangDong
left a comment
XiyangDong
left a comment
There was a problem hiding this comment.
Approving with a bunch of nitpicks
…CP support Add GCP Tekton task (rhelai-gcp) for importing RHEL AI images to GCP. BREAKING CHANGE: Tekton task parameters have been renamed and restructured: - `raw-image-path` renamed to `image-path` - `ami-name` renamed to `image-name` - `replicate-to-regions` renamed to `replicate` - `share-with-account-ids` removed - `credentials` workspace removed — credentials are now provided via K8S secrets referenced by `secret-aws-credentials`, `secret-az-credentials`, or `secret-gcp-credentials` params - Azure env vars renamed to match cloud-importer CLI expectations (AZURE_CLIENT_ID -> ARM_CLIENT_ID, etc.) New parameters added to all tasks: - `operation` (create/destroy) to support destroy from the same task - `force-destroy` and `keep-state` for destroy operations - `tags` for tagging images - `secret-*-credentials` for K8S secret-based credential injection Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Pavol Pitonak <ppitonak@redhat.com>
Collaborator
Author
|
All issues addressed. |
XiyangDong
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…CP support
Add GCP Tekton task (rhelai-gcp) for importing RHEL AI images to GCP.
BREAKING CHANGE: Tekton task parameters have been renamed and restructured:
raw-image-pathrenamed toimage-pathami-namerenamed toimage-namereplicate-to-regionsrenamed toreplicateshare-with-account-idsremovedcredentialsworkspace removed — credentials are now provided via K8S secrets referenced bysecret-aws-credentials,secret-az-credentials, orsecret-gcp-credentialsparamsNew parameters added to all tasks:
operation(create/destroy) to support destroy from the same taskforce-destroyandkeep-statefor destroy operationstagsfor tagging imagessecret-*-credentialsfor K8S secret-based credential injection