Skip to content

feat(tkn): add Tekton task to destroy Azure images#91

Closed
XiyangDong wants to merge 1 commit into
mapt-oss:mainfrom
XiyangDong:aipcc-12954
Closed

feat(tkn): add Tekton task to destroy Azure images#91
XiyangDong wants to merge 1 commit into
mapt-oss:mainfrom
XiyangDong:aipcc-12954

Conversation

@XiyangDong

Copy link
Copy Markdown

cloud-importer destroy is provider-agnostic; swapping the backed-url from s3:// to azblob:// is sufficient to target Azure. This task mirrors the existing AWS destroy pattern with Azure credentials (ARM_CLIENT_ID/SECRET/TENANT_ID/SUBSCRIPTION_ID, AZURE_STORAGE_ACCOUNT, AZURE_STORAGE_KEY) mounted from a secret and the Pulumi state backend hardcoded to azblob://aipcc-productization/cloud-importer.

cloud-importer destroy is provider-agnostic; swapping the backed-url
from s3:// to azblob:// is sufficient to target Azure. This task
mirrors the existing AWS destroy pattern with Azure credentials
(ARM_CLIENT_ID/SECRET/TENANT_ID/SUBSCRIPTION_ID, AZURE_STORAGE_ACCOUNT,
AZURE_STORAGE_KEY) mounted from a secret and the Pulumi state backend
hardcoded to azblob://aipcc-productization/cloud-importer.

Co-authored-by: Claude claude-sonnet-4-6 <noreply@anthropic.com>
Signed-off-by: Xiyang Dong <xdong@redhat.com>
@XiyangDong XiyangDong marked this pull request as draft May 26, 2026 23:50
@XiyangDong XiyangDong marked this pull request as ready for review May 29, 2026 14:39
@adrianriobo

Copy link
Copy Markdown
Contributor

@XiyangDong is this a totally new I though we can use the ones we have just saying create or destroy?

@ppitonak

ppitonak commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

@adrianriobo I guess that Xiyang just replicated what we already had for AWS in my fork https://raw.githubusercontent.com/ppitonak/cloud-importer/refs/heads/tkn_destroy/tkn/destroy-aws.yaml

I originally created a separate "destroy" task because existing tasks were not usable in our environment (they use workspaces) so I couldn't test them properly. I am not sure if anybody even uses them because they reference non-existing image quay.io/mapt-oss/cloud-importer:v1.0.0-dev. This image is actually a reason why I still haven't contributed my task upstream (automation was in progress, process was changing).

Maybe this is a good time to fix all these issues

  1. Latest images are being pushed to ghcr.io/mapt-oss/cloud-importer:latest
  2. releases push images to quay.io/aipcc-cicd/cloud-importer:v${{ env.VERSION }}
  3. Do we want a single task doing both upload and destroy (one task per cloud provider)?

@XiyangDong

Copy link
Copy Markdown
Author

@adrianriobo could you provide some inputs on Pavol's comment?

@ppitonak

Copy link
Copy Markdown
Collaborator

@XiyangDong I updated all tasks based on Adrian's input, it covers also destroying Azure images. #98 PTAL

@XiyangDong

Copy link
Copy Markdown
Author

Close in favor of #98

@XiyangDong XiyangDong closed this Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants